Created attachment 196405 [details]
For Mesa 18.1
Created attachment 196406 [details]
Oops, drop patch that will conflict with bug 230298.
llvm70 is still in RC in the ports tree. I would like to see it get bumped to a release version before this goes in.
I also hope that gecko ports and other big consumers of ports llvm70 gets bumped at the same time. That way there won't be a window where you would need two llvm versions installed.
FYI, llvm70 is definitely currently broken on i386 (it generates lib calls for atomics what we don't implement). dim@ is working on getting the change that caused this fixed.
(In reply to Niclas Zeising from comment #2)
> I also hope that gecko ports and other big consumers of ports llvm70
> gets bumped at the same time. That way there won't be a window
> where you would need two llvm versions installed.
I'd like to start somewhere.
- bug 230790 will bump 10.4/11.1 users to Clang 7.0 but after 10.4/11.1 EOL that change would be nop.
- gecko@ needs clang-sys to support "clang_7_0" bindings or bindgen may crash when building Stylo but, surprisingly, it doesn't, see https://ptpb.pw/mpif
(In reply to Brooks Davis from comment #3)
Mesa doesn't use LLVM for atomics, so the change here builds fine on all Clang architectures. For one, llvmpipe (installed as swrast_dri.so) works fine on 10.4 i386 (tested Firefox 63 with WebRender enabled).
I plan to land this shortly after 2018Q4 branches. Mesa itself needs newer LLVM in order to support recent (mainly AMD) hardware better.
llvm60 is unlikely to receive upstream backports now that llvm70 is stable. Projects that support more than one stable branch are actually rare due to tremendous waste of resources. Even Mesa quickly sunsets previous branch after X.Y.1 release.
As I've stated before, I'd like for this to happen to most of the ports tree at once. Only bumping mesa just means that everyone will need to have two versions of llvm installed in order to get other desktop applications, such as gecko ports.
(In reply to Niclas Zeising from comment #6)
> As I've stated before, I'd like for this to happen to most of the
> ports tree at once.
What's the plan to make this happen?
> Only bumping mesa just means that everyone will need to have two
> versions of llvm installed in order to get other desktop applications,
> such as gecko ports.
Since ports r481071 Gecko ports require llvm70 to build as well.
Ping? Another month has passed.
Can we be clued into the roadmap to llvm70 here?
(In reply to Tobias Kortkamp from comment #8)
We recently switched wayland default to on for mesa ports. I'd like for that to settle before switching this as well. We have a graphics team meeting next week, after that.
Created attachment 199665 [details]
Hop onto DEFAULT_VERSIONS train after ports r485466. Obviously, if x11@ is gonna drag progress during the next bump Mesa would return to the local default.
(In reply to Niclas Zeising from comment #9)
> We have a graphics team meeting next week, after that.
Are you still planning on publishing meeting notes like in October?
(In reply to Tobias Kortkamp from comment #11)
> Are you still planning on publishing meeting notes like in October?
Yes, that's the plan. I'm looking into why this hasn't happened yet.
After bug 235215 lands v2 will switch mesa-* to llvm80. Pick v1 if you want to stay on llvm70.
mesa-dri-18.3.2 with llvm80-8.0.0.r1 and amdgpu needs a backport
of  to avoid
'+vgpr-spilling' is not a recognized feature for this target (ignoring feature)
Created attachment 201531 [details]
beignet + llvm80
(After v2) lang/beignet fails with DEFAULT_VERSIONS+=llvm=80, so here's a fix. Tested on Skylake GT2 via graphics/waifu2x-converter-cpp.
Rationale is in the patch header. I suspect Debian will send a similar fix upstream but given bug 233652 there's not much hope.
A commit references this bug:
Date: Mon Mar 4 10:42:24 UTC 2019
New revision: 494579
graphics/mesa-dri: switch to llvm70
Approved by: maintainer timeout (2 weeks)
A commit references this bug:
Date: Mon Mar 4 10:56:14 UTC 2019
New revision: 494583
graphics/mesa-dri: back out r494579
Landed by mistake. x11@ is immune to maintainer timeout nowadays.
As mesa-* continues to drag updates jumping on LLVM_DEFAULT may become harder in future. The plan is to bump LLVM_DEFAULT to 90 around October.
(In reply to Jan Beich from comment #15)
This patch work for me to build beignet with llvm80.
You can commit it before decided to remove beignet or not.
Any updates here? I do not see anything related to moving Mesa to a newer
LLVM in recent graphics team meeting notes (latest mention in 2019-01-30 notes,
after that nothing).