Bug 230831 - [PATCH] textproc/htmldoc: Do not use arc4random_stir
Summary: [PATCH] textproc/htmldoc: Do not use arc4random_stir
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks: 230756
  Show dependency tree / graph
 
Reported: 2018-08-23 05:06 UTC by Xin LI
Modified: 2018-08-26 08:35 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (jose)

Attachments
Proposed patch (831 bytes, patch)
2018-08-23 05:06 UTC, Xin LI 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xin LI freebsd_committer freebsd_triage 2018-08-23 05:06:40 UTC 
Created attachment 196459 [details]
Proposed patch

arc4random_stir should not be used directly (it's fully automated after r227520, or approximately __FreeBSD_version 1000002), the interface will be removed soon (bug 230756).
Comment 1 Nathan 2018-08-24 01:04:39 UTC 
Currently I'm working on updating this port. Looking at the file the patch refers to, I don't see anything referencing arc4random_stir
Comment 2 Nathan 2018-08-24 01:10:44 UTC 
(In reply to Nathan from comment #1)

This is the only mention I see in configure process with new version:
checking for arc4random... yes
Comment 3 Xin LI freebsd_committer freebsd_triage 2018-08-24 06:52:28 UTC 
(In reply to Nathan from comment #1)
I have took a look at upstream.

Assuming you are updating to the latest version ( https://github.com/michaelrsweet/htmldoc ; I have checked 'master' branch and 'v1.9.3' tag), you should be good (the local patch against htmldoc/html.c should be removed in that case).
Comment 4 Nathan 2018-08-24 11:15:31 UTC 
(In reply to Xin LI from comment #3)
Yea it seems to have been removed as I looked throug that file and didn’t see what this bug issue is
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-08-26 08:27:46 UTC 
A commit references this bug:

Author: delphij
Date: Sun Aug 26 08:26:42 UTC 2018
New revision: 478107
URL: https://svnweb.freebsd.org/changeset/ports/478107

Log:
  textproc/htmldoc: Do not use arc4random_stir.

  (Note that there is an updated version which will solve this too, but I
  am committing this one and will rebase the patch in bug 223721 as it still
  needs maintainer approval).

  PR:		230831, 230756
  Approved by:	portmgr (antoine)

Changes:
  head/textproc/htmldoc/Makefile
  head/textproc/htmldoc/files/patch-htmldoc__http.c