Bug 230835 - [PATCH] security/heimdal: Don't call arc4random_stir
Summary: [PATCH] security/heimdal: Don't call arc4random_stir
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks: 230756 230834
  Show dependency treegraph
 
Reported: 2018-08-23 05:59 UTC by Xin LI
Modified: 2018-08-26 08:48 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (hrs)


Attachments
Proposed patch (1.14 KB, patch)
2018-08-23 05:59 UTC, Xin LI
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xin LI freebsd_committer freebsd_triage 2018-08-23 05:59:16 UTC
Created attachment 196463 [details]
Proposed patch

arc4random_stir should not be called directly (it's fully automated after r227520, or approximately __FreeBSD_version 1000002), the interface will be removed soon (bug 230756).

Please upstream this patch.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-08-26 08:36:55 UTC
A commit references this bug:

Author: delphij
Date: Sun Aug 26 08:36:31 UTC 2018
New revision: 478108
URL: https://svnweb.freebsd.org/changeset/ports/478108

Log:
  security/heimdal: Don't call arc4random_stir.

  PR:		230835, 230756
  Approved by:	portmgr (antoine)

Changes:
  head/security/heimdal/Makefile
  head/security/heimdal/files/patch-lib_roken_rand.c
Comment 2 Xin LI freebsd_committer freebsd_triage 2018-08-26 08:45:04 UTC
Upstreamed as https://github.com/heimdal/heimdal/issues/401 .