Bug 230889 - x11-wm/pekwm: Fix build with Clang 6
Summary: x11-wm/pekwm: Fix build with Clang 6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: http://beefy11.nyi.freebsd.org/data/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-25 13:29 UTC by Tobias Kortkamp
Modified: 2018-08-26 02:40 UTC (History)
1 user (show)

See Also:
natbsd: maintainer-feedback+


Attachments
x11-wm__pekwm.diff (733 bytes, patch)
2018-08-25 13:29 UTC, Tobias Kortkamp
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2018-08-25 13:29:12 UTC
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.
Comment 1 Tobias Kortkamp freebsd_committer 2018-08-25 13:29:32 UTC
Created attachment 196526 [details]
x11-wm__pekwm.diff
Comment 2 Natacha Porté 2018-08-25 19:36:09 UTC
And here I thought I was the only remaining user of this WM, I'm so glad to be wrong \o/

I won't have any easy access to any FreeBSD box in the coming week to double-check that it does work and fix the build, but the change looks good to me and I'm tempted to trust it.
Comment 3 Tobias Kortkamp freebsd_committer 2018-08-26 02:39:19 UTC
(In reply to Natacha Porté from comment #2)
Thanks!
Comment 4 commit-hook freebsd_committer 2018-08-26 02:40:10 UTC
A commit references this bug:

Author: tobik
Date: Sun Aug 26 02:39:12 UTC 2018
New revision: 478092
URL: https://svnweb.freebsd.org/changeset/ports/478092

Log:
  x11-wm/pekwm: Unbreak with Clang 6

  ActionHandler.cc:603:10: error: case value evaluates to 4294967291, which cannot be
        narrowed to type 'int' [-Wc++11-narrowing]
      case WORKSPACE_UP:
           ^

  http://beefy11.nyi.freebsd.org/data/head-i386-default/p474051_s336054/logs/pekwm-0.1.17_4,1.log

  PR:		230889
  Submitted by:	tobik
  Approved by:	Natacha Port? <natbsd@instinctive.eu> (maintainer)

Changes:
  head/x11-wm/pekwm/Makefile