Bug 230892 - textproc/randlm: Fix build with Clang 6
Summary: textproc/randlm: Fix build with Clang 6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Sivachenko
URL: http://beefy11.nyi.freebsd.org/data/h...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-25 14:45 UTC by Tobias Kortkamp
Modified: 2018-08-27 17:14 UTC (History)
0 users

See Also:
demon: maintainer-feedback+


Attachments
textproc__randlm.diff (350 bytes, patch)
2018-08-25 14:46 UTC, Tobias Kortkamp
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer 2018-08-25 14:45:53 UTC
The build fails with Clang 6 and soon the port will be marked as
BROKEN on 12.0 and 11.2 if we do not act.
Comment 1 Tobias Kortkamp freebsd_committer 2018-08-25 14:46:16 UTC
Created attachment 196532 [details]
textproc__randlm.diff
Comment 2 commit-hook freebsd_committer 2018-08-27 17:14:27 UTC
A commit references this bug:

Author: tobik
Date: Mon Aug 27 17:13:43 UTC 2018
New revision: 478232
URL: https://svnweb.freebsd.org/changeset/ports/478232

Log:
  textproc/randlm: Fix build with Clang 6

  In file included from RandLMBuilder.cpp:17:
  In file included from ./RandLMBuilder.h:21:
  In file included from ./RandLMPipelineTool.h:20:
  In file included from ./RandLMPipeline.h:20:
  In file included from ./RandLMPreproc.h:25:
  In file included from ./RandLM.h:23:
  ./RandLMQuantiser.h:41:24: error: in-class initializer for static data member of type 'const float' requires 'constexpr' specifier [-Wstatic-float-init]
      static const float kFloatErr = 0.00001f;
                         ^           ~~~~~~~~
  ./RandLMQuantiser.h:41:5: note: add 'constexpr'
      static const float kFloatErr = 0.00001f;
      ^
      constexpr

  http://beefy11.nyi.freebsd.org/data/head-i386-default/p477696_s338122/logs/errors/randlm-0.2.5_13.log

  PR:		230892
  Submitted by:	tobik
  Approved by:	demon (maintainer)

Changes:
  head/textproc/randlm/Makefile