Bug 230917 - [patch] x11-wm/libcompizconfig: correct LICENSE; add a missing dependency and option NLS
Summary: [patch] x11-wm/libcompizconfig: correct LICENSE; add a missing dependency and...
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koichiro Iwao
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2018-08-26 15:41 UTC by Samy Mahmoudi
Modified: 2019-02-13 03:11 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd-ports)


Attachments
Patch file generated with svn diff (1.99 KB, patch)
2018-08-26 15:41 UTC, Samy Mahmoudi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samy Mahmoudi 2018-08-26 15:41:56 UTC
Created attachment 196570 [details]
Patch file generated with svn diff

Hi,

• Correct LICENSE (GPLv2 ---> GPLv2+)
• Add a missing dependency
• Add option NLS
• Regenerate a patch file
• Bump PORTREVISION (Makefile changed to enable a compile-time option)
Comment 1 Koichiro Iwao freebsd_committer 2019-02-11 16:56:54 UTC
maintainer timeout?
Comment 2 Samy Mahmoudi 2019-02-11 22:29:04 UTC
(In reply to Koichiro Iwao from comment #1)

Commit under maintainer timeout already requested for this patch and various others.

As I was not using neither poudriere nor portlint at that time, I provided a patch incorrect in some way, which results in one of these requests being postponed.

To ease in review, I cancelled all the other requests so that I could check myself the patches with poudriere/portlint rather than losing committers' time...
Comment 3 Koichiro Iwao freebsd_committer 2019-02-12 02:34:25 UTC
testbuild by poudriere failed. USES=gettext seems to be needed.
Comment 4 Samy Mahmoudi 2019-02-12 08:54:50 UTC
(In reply to Koichiro Iwao from comment #3)

I will try to sort out this problem today.
Comment 5 Samy Mahmoudi 2019-02-13 03:11:41 UTC
(In reply to Koichiro Iwao from comment #3)

I am working on it and will update the patch as soon as possible.