Bug 230939 - x11-fm/krusader2-kde4: fails to build with clang 7
Summary: x11-fm/krusader2-kde4: fails to build with clang 7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: kde
URL:
Keywords: needs-patch
Depends on:
Blocks: 230355
  Show dependency treegraph
 
Reported: 2018-08-27 14:16 UTC by Jan Beich
Modified: 2018-09-07 10:10 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2018-08-27 14:16:51 UTC
$ poudriere jail -cj clang7 -a amd64 -v projects/clang700-import -m svn+https
$ poudriere testport -j clang7 x11-fm/krusader2-kde4
[...]
krusader/Konfigurator/kgarchives.cpp:170:37: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do Tar")->setEnabled(PS("tar"));
                                    ^~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:171:38: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do GZip")->setEnabled(PS("gzip"));
                                     ^~~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:172:39: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do BZip2")->setEnabled(PS("bzip2"));
                                      ^~~~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:173:38: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do LZMA")->setEnabled(PS("lzma"));
                                     ^~~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:174:36: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do XZ")->setEnabled(PS("xz"));
                                   ^~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:175:39: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do UnZip")->setEnabled(PS("unzip"));
                                      ^~~~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:176:37: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do Lha")->setEnabled(PS("lha"));
                                    ^~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:177:37: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do RPM")->setEnabled(PS("rpm") || PS("cpio"));
                                    ^~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:177:50: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do RPM")->setEnabled(PS("rpm") || PS("cpio"));
                                                 ^~~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:178:39: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do UnRar")->setEnabled(PS("unrar") || PS("rar"));
                                      ^~~~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:178:54: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do UnRar")->setEnabled(PS("unrar") || PS("rar"));
                                                     ^~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:179:39: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do UnAce")->setEnabled(PS("unace"));
                                      ^~~~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:180:39: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do Unarj")->setEnabled(PS("unarj") || PS("arj"));
                                      ^~~~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:180:54: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do Unarj")->setEnabled(PS("unarj") || PS("arj"));
                                                     ^~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:181:37: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do DEB")->setEnabled(PS("dpkg") && PS("tar"));
                                    ^~~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:181:51: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do DEB")->setEnabled(PS("dpkg") && PS("tar"));
                                                  ^~~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
krusader/Konfigurator/kgarchives.cpp:182:36: error: ordered comparison between pointer and zero ('const void *' and 'int')
    cbs->find("Do 7z")->setEnabled(PS("7z"));
                                   ^~~~~~~~
krusader/Konfigurator/kgarchives.cpp:166:30: note: expanded from macro 'PS'
#define PS(x) lst.contains(x)>0
              ~~~~~~~~~~~~~~~^~
17 errors generated.

http://package18.nyi.freebsd.org/data/headamd64PR230355gnucxx98-default/2018-08-26_10h16m34s/logs/errors/krusader-kde4-2.4.0.b3_6.log
Comment 1 commit-hook freebsd_committer 2018-08-30 09:57:33 UTC
A commit references this bug:

Author: adridg
Date: Thu Aug 30 09:56:49 UTC 2018
New revision: 478438
URL: https://svnweb.freebsd.org/changeset/ports/478438

Log:
  Fix clang7 build.

  PR:		230939
  Reported by:	jbeich

Changes:
  head/x11-fm/krusader2-kde4/files/patch-krusader_Dialogs_packgui.cpp
  head/x11-fm/krusader2-kde4/files/patch-krusader_Konfigurator_kgarchives.cpp
  head/x11-fm/krusader2-kde4/files/patch-krusader_Konfigurator_krresulttable.cpp
  head/x11-fm/krusader2-kde4/files/patch-krusader_MountMan_kmountman.cpp