Bug 230947 - japanese/kiten-kde4: fails to build with clang 7
Summary: japanese/kiten-kde4: fails to build with clang 7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords: needs-patch
Depends on:
Blocks: 230355
  Show dependency tree / graph
 
Reported: 2018-08-27 14:30 UTC by Jan Beich
Modified: 2018-09-07 10:04 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (kde)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2018-08-27 14:30:06 UTC 
$ poudriere jail -cj clang7 -a amd64 -v projects/clang700-import -m svn+https
$ poudriere testport -j clang7 japanese/kiten-kde4
[...]
lib/dictquery.cpp:462:40: error: ordered comparison between pointer and zero ('const void *' and 'int')
  return d->entryOrder.contains( key ) > 0;
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

http://package18.nyi.freebsd.org/data/headamd64PR230355gnucxx98-default/2018-08-26_10h16m34s/logs/errors/ja-kiten-kde4-4.14.3_4.log
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-08-27 21:20:43 UTC 
A commit references this bug:

Author: adridg
Date: Mon Aug 27 21:19:57 UTC 2018
New revision: 478254
URL: https://svnweb.freebsd.org/changeset/ports/478254

Log:
  Fix build of EOL software against modern clang.

  Lots of KDE4 software contains this strange > 0 comparison for bools,
  fix japanese/kiten-kde4 here.

  PR:		230947
  Reported by:	jbeich

Changes:
  head/japanese/kiten-kde4/files/
  head/japanese/kiten-kde4/files/patch-lib_dictquery.cpp