Bug 230951 - print/cups-filters: fix rc.d/cups_browsed to handle cups_browsed_flags as expected
Summary: print/cups-filters: fix rc.d/cups_browsed to handle cups_browsed_flags as exp...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-27 15:05 UTC by J.R. Oldroyd
Modified: 2018-12-14 17:42 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (tijl)


Attachments
replacement for files/cups_browsed.in (751 bytes, application/x-shellscript)
2018-08-27 15:05 UTC, J.R. Oldroyd
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description J.R. Oldroyd 2018-08-27 15:05:29 UTC
Created attachment 196601 [details]
replacement for files/cups_browsed.in

As it stands, rc.d/cups_browsed invokes /usr/sbin/daemon using the run_rc_command mechanism.  Using /usr/sbin/daemon is necessary but the way it is invoked is wrong because rc.d vars like cups_browsed_flags are passed to the /usr/sbin/daemon command and not the /usr/local/sbin/cups-browsed command as expected.

Attached file is a replacement for files/cups_browsed.in which defines a cups_browsed_start start_command in the script and handles the cups_browsed_flags variable as expected.

Being able to pass command line flags to /usr/local/sbin/cups-browsed is important in order to avoid having to make config changes in /usr/local/etc/cups/cups-browsed.conf on many client systems.
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2018-08-28 11:52:44 UTC
Thanks, I'll include it in the next update of the port.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-12-14 17:42:07 UTC
A commit references this bug:

Author: tijl
Date: Fri Dec 14 17:41:41 UTC 2018
New revision: 487453
URL: https://svnweb.freebsd.org/changeset/ports/487453

Log:
  - Update to 1.21.5.
  - Fix support for cups_browsed_flags in the cups_browsed rc.d script.  The
    flags were passed to daemon(8) instead of cups_browsed. [1]

  PR:		230951 [1]
  Submitted by:	J.R. Oldroyd <fbsd@opal.com> [1]

Changes:
  head/print/cups-filters/Makefile
  head/print/cups-filters/distinfo
  head/print/cups-filters/files/cups_browsed.in