Created attachment 196618 [details]
FAAC - FAAC AAC encoder support
FAAD - FAAD AAC decoder support
GSM - GSM codec support
JPEG - JPEG image format support
LAME - LAME MP3 audio encoder support
OPENH264 - H.264 video codec support via OpenH264
PCSC - Smart card support (smart card device redirection)
I'm happy if FAAC/FAAD options are enabled by default.
Let maintainer decide this.
Patch looks good to me; I'm indifferent as to whether or not FAAC/FAAD should be defaults or not.
(In reply to Koichiro Iwao from comment #1)
Can you please commit this, since I'm not a ports committer? It has my approval whether you leave it as-is or set FAAC/FAAD as defaults.
(In reply to Kyle Evans from comment #5)
Sorry I missed your reply. I'll take this now.
The patch needs to be modified since JPEG codec has been removed from FreeRDP.
Are you sure?
set(JPEG_FEATURE_DESCRIPTION "use JPEG library")
-- Skipping recommended feature GStreamer_1_0 for multimedia (multimedia redirection, audio and video playback)
-- Finding optional feature JPEG for codec (use JPEG library)
-- Found JPEG: /usr/local/lib/libjpeg.so (found version "80")
-- Skipping optional feature x264 for codec (use x264 library)
-- Enable feature x264 using "-DWITH_X264=ON"
cmake -L .
Read the link.(In reply to rozhuk.im from comment #7)
(In reply to Koichiro Iwao from comment #6)
A bit more options:
DIRECTFB - DirectFB graphics support
SOXR - SoX resampler support via libsoxr
Created attachment 200503 [details]
add few opts
PS: I'm not sure that this work:
Probably there is shoud be 2 options ON: WITH_GSSAPI and WITH_GSSAPI_HEIMDAL
cant test it because mine system without kerberos.
Created attachment 200516 [details]
replace truncated patch
Created attachment 200518 [details]
DirectFB option has been removed at r428330. Is esurrecting the option worth enough?
Created attachment 203714 [details]
Remove DIRECTFB option
I see directfb unpopular technology in ports tree. Removed.
(In reply to rozhuk.im from comment #16)
Please feel free to commit this at your discretion with my approval. Assuming it passes Q/A, I'm happy and we can always fiddle with defaults later if needed.
A commit references this bug:
Date: Tue Apr 16 20:53:30 UTC 2019
New revision: 499122
net/freerdp: add some options
Additionally, pet portlint a bit while I'm here.
Submitted by: Ivan Rozhuk <email@example.com>
Approved by: kevans (maintainer)