Bug 231001 - dns/knot2: [patch] Update to 2.7.2
Summary: dns/knot2: [patch] Update to 2.7.2
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://www.knot-dns.cz/2018-08-29-ve...
Keywords:
: 230841 (view as bug list)
Depends on:
Blocks: 230842
  Show dependency tree / graph
 
Reported: 2018-08-29 17:09 UTC by Leo Vandewoestijne
Modified: 2018-10-17 05:06 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+

Attachments
knot 2.7.2 (6.37 KB, text/plain)
2018-08-29 17:09 UTC, Leo Vandewoestijne 		freebsd: maintainer-approval+
Details
knot 2.7.2 ...better? (6.33 KB, patch)
2018-09-05 10:29 UTC, Leo Vandewoestijne 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Vandewoestijne 2018-08-29 17:09:11 UTC 
Created attachment 196685 [details]
knot 2.7.2

This is the patch to update knot2 to 2.7.2

Additional info:

- It contains the patches of PR229732 - but doesn't seem to solve the problem (but still improves some troubles).

- It bypasses PR230841 (version 2.7.1)

- The lack of PR230841 of this PR is blocking PR230842 (as knot-resolver requires a newer libknot).

- I've tested it successful, both manual and in poudries, for all current FreeBSD versions on i386 and amd64.
Comment 1 Leo Vandewoestijne 2018-08-29 17:16:27 UTC 
*** Bug 230841 has been marked as a duplicate of this bug. ***
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2018-09-02 09:18:07 UTC 
Fails to build with all options unset on current (11.2a, 11.1a, 10.4i are fine).

http://people.freebsd.org/~pi/logs/dns__knot2-cur-1535879174.txt

Any ideas ?
Comment 3 Nathan 2018-09-04 11:29:06 UTC 
Fails to apply cleanly for me

@Kurt: looks like a linker issue; try either adding LLD_UNSAFE=yes or add -fPIC to cflags
Comment 4 Leo Vandewoestijne 2018-09-05 10:29:44 UTC 
Created attachment 196884 [details]
knot 2.7.2 ...better?

I tried this patch, identical to previous - plus the LLD_UNSAFE set. Setup a new 11.2 server (all vanilla) with fresh poudriere jails (10.4/11.1/11.2/12.0-ALPHA4).
And (again) all is fine, except for what was already anticipated on (i386 on 11.2 / 12.0).

Then I also tried without LLD_UNSAFE, in hope to replicate the linker error, but I'm unable to so.
Comment 5 Leo Vandewoestijne 2018-10-15 13:51:46 UTC 

*** This bug has been marked as a duplicate of bug 232284 ***