Bug 231016 - games/stormbaancoureur: Use pkg-config for libode.so
Summary: games/stormbaancoureur: Use pkg-config for libode.so
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks: 230359
  Show dependency tree / graph
 
Reported: 2018-08-30 07:06 UTC by Yuri Victorovich
Modified: 2019-02-21 20:59 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)

Attachments
patch (1.08 KB, patch)
2018-08-30 07:06 UTC, Yuri Victorovich 		no flags Details | Diff
patch (1.30 KB, patch)
2018-08-30 07:06 UTC, Yuri Victorovich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2018-08-30 07:06:05 UTC 
Created attachment 196698 [details]
patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-30 07:06:35 UTC 
Created attachment 196699 [details]
patch
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2018-08-30 13:55:31 UTC 
What's the purpose?
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-08-30 15:30:50 UTC 
(In reply to Dmitry Marakasov from comment #2)

Static lib is hard-coded against of what `pkg-config --libs ode` says.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-21 20:56:45 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu Feb 21 20:55:42 UTC 2019
New revision: 493533
URL: https://svnweb.freebsd.org/changeset/ports/493533

Log:
  - Avoid static linking with ode [1]
  - Switch to more correct way of avoiding C++11 related build errors
  - Switch to options helpers

  PR:		231016 [1]
  Submitted by:	yuri@freebsd.org [1]

Changes:
  head/games/stormbaancoureur/Makefile
  head/games/stormbaancoureur/files/patch-src-stormbaancoureur-Makefile
  head/games/stormbaancoureur/files/patch-src-stormbaancoureur_Makefile