Bug 231066 - lang/gcc*: allow building w/o gets
Summary: lang/gcc*: allow building w/o gets
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gerald Pfeifer
URL:
Keywords:
Depends on:
Blocks: 222796
  Show dependency treegraph
 
Reported: 2018-09-01 01:20 UTC by Ed Maste
Modified: 2018-09-30 07:41 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer 2018-09-01 01:20:47 UTC
We intend to remove gets() - see PR 228914 and review D12298 https://reviews.freebsd.org/D12298. gcc ports fail to build without gets due to __gets_chk in libssp; on a gets-less system gcc should omit this support from libssp.
Comment 1 commit-hook freebsd_committer 2018-09-01 20:18:22 UTC
A commit references this bug:

Author: gerald
Date: Sat Sep  1 20:17:46 UTC 2018
New revision: 478722
URL: https://svnweb.freebsd.org/changeset/ports/478722

Log:
  Disable the build/use of libssp/gets-chk since FreeBSD 12 and later
  do not feature gets() any longer.

  PR:		222796, 231066
  Differential Revision:	https://reviews.freebsd.org/D12298

Changes:
  head/lang/gcc7/files/patch-gets-no-more
Comment 2 Gerald Pfeifer freebsd_committer 2018-09-01 20:33:06 UTC
I reported the situation around GCC upstream, which did not lead to a
code change yet.

Thus I'm moving forward to patch important lang/gcc* ports -- initially 
lang/gcc7 as the default, next lang/gcc8 as the future default, and 
lang/gcc9-devel -- still hoping for some updates to come in upstream.

The following I plan to leave as is, and mark as BROKEN on FreeBSD 12
when it comes to that

 - older versions of GCC, and 
 - devel versions that are actively maintained upstream still and feature
   a stable sibling that tracks the same release branch.

Users should hardly need those, let alone in combination with FreeBSD 12,
and I'm hoping for the -devel ports to be ready when FreeBSD 12 goes live
for real.
Comment 3 commit-hook freebsd_committer 2018-09-02 00:09:19 UTC
A commit references this bug:

Author: gerald
Date: Sun Sep  2 00:08:51 UTC 2018
New revision: 478752
URL: https://svnweb.freebsd.org/changeset/ports/478752

Log:
  Forward port r478722 | gerald | 2018-09-01 from lang/gcc7:

  Disable the build/use of libssp/gets-chk since FreeBSD 12 and later
  do not feature gets() any longer.

  PR:		222796, 231066
  Differential Revision:	https://reviews.freebsd.org/D12298

Changes:
  head/lang/gcc8/files/patch-gets-no-more
Comment 4 commit-hook freebsd_committer 2018-09-08 08:17:56 UTC
A commit references this bug:

Author: gerald
Date: Sat Sep  8 08:16:55 UTC 2018
New revision: 479233
URL: https://svnweb.freebsd.org/changeset/ports/479233

Log:
  Forward port r478722 | gerald | 2018-09-01 from lang/gcc7:

  Disable the build/use of libssp/gets-chk since FreeBSD 12 and later
  do not feature gets() any longer.

  (I was planning to make this part of a routine update, alas last week's
  snapshot was broken on i386-unknown-freebsd10.x and so will this week's
  still.)

  PR:		222796, 231066
  Differential Revision:	https://reviews.freebsd.org/D12298

Changes:
  head/lang/gcc9-devel/files/patch-gets-no-more
Comment 5 commit-hook freebsd_committer 2018-09-30 07:36:03 UTC
A commit references this bug:

Author: gerald
Date: Sun Sep 30 07:35:17 UTC 2018
New revision: 480939
URL: https://svnweb.freebsd.org/changeset/ports/480939

Log:
  Recommend the use of GCC 7 or later over this port, since that is now
  the default version of GCC for the Ports Collection.

  And backport r478722 | gerald | 2018-09-01 from lang/gcc7: [1]

  Disable the build/use of libssp/gets-chk since FreeBSD 12 and later
  do not feature gets() any longer.

  PR:		222796, 231066 [1]
  Differential Revision:	https://reviews.freebsd.org/D12298 [1]

Changes:
  head/lang/gcc5/Makefile
  head/lang/gcc5/files/patch-gets-no-more
Comment 6 Gerald Pfeifer freebsd_committer 2018-09-30 07:41:00 UTC
I believe sufficiently many of the lang/gcc* ports have now been patches
to be able to close this report, namely all that should be relevant for
regular use. 

(I'll still see that we hopefully can get this addressed upstream as well,
which should then flow back into the -devel ports and obviate the need for
local patches.)