Bug 231142 - comms/freedv: Update 1.3.1
Summary: comms/freedv: Update 1.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-04 04:19 UTC by takefu
Modified: 2018-09-11 05:17 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (hamradio)

Attachments
freedv-1.3.1.patch (1.52 KB, patch)
2018-09-04 04:19 UTC, takefu 		no flags Details | Diff
freedv-1.3.1.patch_2 (2.53 KB, patch)
2018-09-11 04:20 UTC, takefu 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description takefu 2018-09-04 04:19:28 UTC 
Created attachment 196844 [details]
freedv-1.3.1.patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-09-04 06:38:54 UTC 
It fails to build on 11.2 amd64:
/usr/ports/comms/freedv/work/freedv-1.3.1/src/fdmdv2_main.cpp:1203:52: error: no member named 'sync_metric' in 'MODEM_STATS'
        sprintf(syncmetric, "Sync: %3.2f", g_stats.sync_metric);
                                           ~~~~~~~ ^
1 error generated.
Comment 2 takefu 2018-09-07 07:01:44 UTC 
(In reply to Yuri Victorovich from comment #1)

Audio/CODEC2 version 0.8?
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2018-09-07 07:06:59 UTC 
(In reply to takefu from comment #2)

yes
Comment 4 takefu 2018-09-11 04:20:00 UTC 
Created attachment 197019 [details]
freedv-1.3.1.patch_2

10.4-RELEASE-p11 ix86/amd64
11.2-RELEASE-p1 amd64
12-current r337191 amd64

I tried it in this environment, but it didn't reproduce.
Sure, but audio/codec2 is using 0.8.1, right?
Anyway, I made an ad hoc patch, so try it.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2018-09-11 05:17:35 UTC 
Committed, thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2018-09-11 05:17:49 UTC 
A commit references this bug:

Author: yuri
Date: Tue Sep 11 05:17:30 UTC 2018
New revision: 479501
URL: https://svnweb.freebsd.org/changeset/ports/479501

Log:
  comms/freedv: Update 1.2.2 -> 1.3.1

  Port changes:
  * Change MASTER_SITES
  * WWW update

  PR:		231142
  Submitted by:	takefu@airport.fm

Changes:
  head/comms/freedv/Makefile
  head/comms/freedv/distinfo
  head/comms/freedv/files/patch-src__fdmdv2_main.cpp
  head/comms/freedv/pkg-descr