Bug 231307 - [NEW PORT] x11-fonts/raleway: Raleway font
Summary: [NEW PORT] x11-fonts/raleway: Raleway font
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-11 20:03 UTC by Florian Limberger
Modified: 2018-11-05 21:24 UTC (History)
1 user (show)

See Also:


Attachments
Patch to add the raleway font (3.17 KB, patch)
2018-09-11 20:03 UTC, Florian Limberger
no flags Details | Diff
Patch to add the raleway font (2.87 KB, patch)
2018-10-31 22:30 UTC, Florian Limberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Limberger 2018-09-11 20:03:36 UTC
Created attachment 197028 [details]
Patch to add the raleway font

An elegant sans-serif, designed in a single thin weight.
Comment 1 Tobias Kortkamp freebsd_committer 2018-10-30 20:18:32 UTC
(In reply to Florian Limberger from comment #0)
+COMMENT=	An elegant sans-serif, designed in a single thin weight.

Can you update COMMENT with the rules from [1] in mind?

+GH_PROJECT=	raleway

Drop this.  GH_PROJECT defaults to ${PORTNAME} so it's not needed here.

+do-install:
+	${MKDIR} ${STAGEDIR}${DOCSDIR}
+	cd ${WRKSRC} && ${INSTALL_DATA} readme.markdown ${STAGEDIR}${DOCSDIR}

If you install something in DOCSDIR than the port needs a DOCS option.

--- x11-fonts/raleway/pkg-plist	(nonexistent)
+++ x11-fonts/raleway/pkg-plist	(working copy)
@@ -0,0 +1,2 @@
+%%DOCSDIR%%/readme.markdown
+%%FONTSDIR%%/Raleway Thin.otf

The port only installs 2 files, so this should be replaced by PLIST_FILES
and PORTDOCS.

Please confirm that this passes QA i.e. portlint and poudriere testport.

[1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-comment.html
Comment 2 Tobias Kortkamp freebsd_committer 2018-10-30 20:20:58 UTC
(In reply to Tobias Kortkamp from comment #1)
A more detailed pkg-descr with at least a paragraph or two would be nice too.
The first paragraph from WWW will probably do.
Comment 3 Florian Limberger 2018-10-31 10:03:13 UTC
(In reply to Tobias Kortkamp from comment #1)

IIRC portlint did pass, but I will check again in the evening when I implemented your suggested changes.
Regarding poudiere, I do not have an installation as I usually use packages. Is there another way or should I bite the bullet and set up a local instance?
Comment 4 Florian Limberger 2018-10-31 22:30:53 UTC
Created attachment 198827 [details]
Patch to add the raleway font

(In reply to Tobias Kortkamp from comment #1)

Whatever I did, I messed up the portlint checks.
This patch is better, but I have to update the patches for all my other added fonts.
Comment 5 Tobias Kortkamp freebsd_committer 2018-11-05 21:21:39 UTC
(In reply to Florian Limberger from comment #3)
> Regarding poudiere, I do not have an installation as I usually use packages.
> Is there another way or should I bite the bullet and set up a local instance?

You should bite the bullet.  Poudriere is what is used to build the packages
on pkg.FreeBSD.org, so testing new ports with it gives us (and yourself) more
confidence that a patch is good and works.

(In reply to Florian Limberger from comment #4)
Looks very good to me. Thanks.
Comment 6 commit-hook freebsd_committer 2018-11-05 21:23:38 UTC
A commit references this bug:

Author: tobik
Date: Mon Nov  5 21:22:55 UTC 2018
New revision: 484223
URL: https://svnweb.freebsd.org/changeset/ports/484223

Log:
  New port: x11-fonts/raleway

  Raleway is an elegant sans-serif typeface, designed in a single
  thin weight.  It is a display face that features both old style and
  lining numerals, standard and discretionary ligatures, a pretty
  complete set of diacritics, as well as a stylistic alternate inspired
  by more geometric sans-serif typefaces than it's neo-grotesque
  inspired default character set.

  WWW: https://www.theleagueofmoveabletype.com/raleway

  PR:		231307
  Submitted by:	Florian Limberger <flo@snakeoilproductions.net>

Changes:
  head/x11-fonts/Makefile
  head/x11-fonts/raleway/
  head/x11-fonts/raleway/Makefile
  head/x11-fonts/raleway/distinfo
  head/x11-fonts/raleway/pkg-descr