Bug 231317 - [patch] www/chromium: Change USE_GL to become USES=gl
Summary: [patch] www/chromium: Change USE_GL to become USES=gl
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Carlos J. Puga Medina
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-12 03:13 UTC by Samy Mahmoudi
Modified: 2019-01-07 19:51 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (chromium)


Attachments
Patch file generated with svn diff (514 bytes, patch)
2018-09-12 03:13 UTC, Samy Mahmoudi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samy Mahmoudi 2018-09-12 03:13:18 UTC
Created attachment 197042 [details]
Patch file generated with svn diff

Change USE_GL to become USES=gl

Change USE_GL to become USES=gl. You still need to specify USE_GL as well,
to specify which gl components you need, such as egl glesv2 glut glu glw gl.
Only specifying USE_GL is supported for now, to ease in transition. It is
however deprecated, and will be removed eventually.
Specifying USES=gl without USE_GL is an error.
USE_GL=yes is also deprecated, but supported for now. It implies USE_GL=glu.

Fix fallout from this change.

PR: 230692
Approved by: portmgr (antoine)
exp-run by: antoine
Reviewed by: mat
Differential Revision: https://reviews.freebsd.org/D16774
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-09-16 22:28:56 UTC
As far as I'm concerned, chromium/iridium build fine and it's not necessary to add the patch.
Comment 2 Samy Mahmoudi 2018-09-17 19:42:58 UTC
Indeed, the attached patch is not necessary to build chromium now, but it will be.

The patch makes www/chromium comply with the new USE_GL standard: "Only specifying USE_GL is supported for now, to ease in transition. It is however deprecated, and will be removed eventually." It also disables the corresponding warning.
Comment 3 Carlos J. Puga Medina freebsd_committer freebsd_triage 2018-11-04 13:59:39 UTC
(In reply to Samy Mahmoudi from comment #2)

I'll commit the USES=gl change with the next chromium update.
Comment 4 Samy Mahmoudi 2018-11-04 16:34:50 UTC
Thank you for your upcoming commit.
Comment 5 Carlos J. Puga Medina freebsd_committer freebsd_triage 2019-01-07 19:51:09 UTC
(In reply to Samy Mahmoudi from comment #4)

Fixed in r489612.