Bug 231333 - security/openssl-devel builds dynamically linked bin/openssl when shared libraries are disabled
Summary: security/openssl-devel builds dynamically linked bin/openssl when shared libr...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-12 23:09 UTC by Lev A. Serebryakov
Modified: 2018-10-28 16:10 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (brnrd)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lev A. Serebryakov freebsd_committer 2018-09-12 23:09:03 UTC
`security/openssl-devel' port builds dynamically linked `bin/openssl' command even if SHARED option is turned off:

# /usr/local/bin/openssl
ld-elf.so.1: Shared object "libssl.so.10" not found, required by "openssl"
#
Comment 1 Bernard Spil freebsd_committer 2018-09-13 10:38:34 UTC
Confirmed. 'shared' is missing in line 92 of the makefile.
>	rmd160 sse2 threads tls1 tls1_1 zlib
>	rmd160 shared sse2 threads tls1 tls1_1 zlib

Can you please locally add that and test? My ports tree is in a bit of a disheveled state with a rename of openssl-devel to openssl110.

After that change
build# ldd /usr/local/bin/openssl
/usr/local/bin/openssl:
        libthr.so.3 => /lib/libthr.so.3 (0x800ae6000)
        libc.so.7 => /lib/libc.so.7 (0x800d0e000)
build# /usr/local/bin/openssl
OpenSSL> version
OpenSSL 1.1.0i  14 Aug 2018

Part of my local tree, will land in next commit.
Comment 2 Lev A. Serebryakov freebsd_committer 2018-09-13 11:05:52 UTC
Yep, it helps me.
Comment 3 commit-hook freebsd_committer 2018-10-28 14:53:25 UTC
A commit references this bug:

Author: brnrd
Date: Sun Oct 28 14:52:35 UTC 2018
New revision: 483302
URL: https://svnweb.freebsd.org/changeset/ports/483302

Log:
  security/openssl-devel: Fix SHARED option

   - Fix linking with lld on i386
   - Fix ordering

  PR:		231333
  Reported by:	lev

Changes:
  head/security/openssl-devel/Makefile