Bug 231544 - print/harfbuzz: fix build on GCC-based architectures
Summary: print/harfbuzz: fix build on GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-21 13:17 UTC by Piotr Kubaj
Modified: 2018-09-23 21:16 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
patch (428 bytes, patch)
2018-09-21 13:17 UTC, Piotr Kubaj 		no flags Details | Diff
v2 (613 bytes, patch)
2018-09-22 05:55 UTC, Piotr Kubaj 		jbeich: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-09-21 13:17:33 UTC 
Created attachment 197302 [details]
patch

Compiling harfbuzz on powerpc64 fails with:
/usr/local/lib/libgraphite2.so: undefined reference to `__cxa_throw_bad_array_new_length@CXXABI_1.3.8'

USES=compiler:c++11-lang is necessary to fix this.

Tested on amd64 and powerpc64.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2018-09-21 21:19:21 UTC 
Comment on attachment 197302 [details]
patch

>Index: Makefile
>===================================================================
>--- Makefile	(revision 480254)
>+++ Makefile	(working copy)
>@@ -14,7 +14,7 @@
> 		libgraphite2.so:graphics/graphite2
> 
> USE_LDCONFIG=	yes
>-USES=		gettext-runtime gmake gnome libtool \
>+USES=		compiler:c++11-lang gettext-runtime gmake gnome libtool \

USES=compiler:c++11-lib is already defined under for -icu slave. Just move that into master port to fix libstdc++ ABI mismatch.

USES=compiler:c++11-lang unlike *-lib variant didn't force new libstdc++ on FreeBSD 9.* amd64/i386 but nowadays both are synonyms for platforms stuck with in-base GCC.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-09-22 05:55:18 UTC 
Created attachment 197329 [details]
v2

Thanks for the clarification about the difference between lang and lib (I wondered about it myself).

Here's a new patch.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2018-09-23 21:10:57 UTC 
Comment on attachment 197329 [details]
v2

I'm not the maintainer but the fix looks OK.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-09-23 21:15:27 UTC 
A commit references this bug:

Author: jbeich
Date: Sun Sep 23 21:15:06 UTC 2018
New revision: 480533
URL: https://svnweb.freebsd.org/changeset/ports/480533

Log:
  print/harfbuzz: unbreak on GCC archs after r477696

  /usr/local/lib/libgraphite2.so: undefined reference to `__cxa_throw_bad_array_new_length@CXXABI_1.3.8'

  PR:		231544
  Submitted by:	Piotr Kubaj

Changes:
  head/print/harfbuzz/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-09-23 21:16:30 UTC 
A commit references this bug:

Author: jbeich
Date: Sun Sep 23 21:16:18 UTC 2018
New revision: 480534
URL: https://svnweb.freebsd.org/changeset/ports/480534

Log:
  MFH: r480533

  print/harfbuzz: unbreak on GCC archs after r477696

  /usr/local/lib/libgraphite2.so: undefined reference to `__cxa_throw_bad_array_new_length@CXXABI_1.3.8'

  PR:		231544
  Submitted by:	Piotr Kubaj
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2018Q3/
  branches/2018Q3/print/harfbuzz/Makefile