Created attachment 197378 [details] Update chinese/fcitx to 4.2.9.6 Please update chinese/fcitx to 4.2.9.6.
From bug #231611: > Gnome is required in your patch, can you show me why it's necessary? Without USES=gnome, Ports framework warns "Using USE_GNOME alone is deprecated, please add USES=gnome.".
(In reply to Ryo ONODERA from comment #1) I see. This week I'm traveling; I will verify the new version during next weekend.
Hi, Ryo ONODERA : x11/xkeyboard-config should be added as depends. And even with it , the build failed on 10.4-i386 with the error as below. Would you test it again ? wen --- src/frontend/qt/CMakeFiles/qtim-fcitx.dir/qtkey.cpp.o --- [ 40%] Building CXX object src/frontend/qt/CMakeFiles/qtim-fcitx.dir/qtkey.cpp.o cd /wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6/src/frontend/qt && /usr/bin/c++ -Dqtim_fcitx_EXPORTS -I/wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6/src/frontend/qt/qtim-fcitx_autogen/include -I/wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6 -I/wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6/src -I/wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6/src/lib -I/usr/local/include/qt4 -I/usr/local/include/qt4/QtCore -I/usr/local/include/qt4/QtGui -I/usr/local/include/qt4/QtDBus -I/wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6/src/frontend/qt -I/usr/local/include -Wall -Wextra -Wno-sign-compare -Wno-unused-parameter -fvisibility=hidden -O2 -pipe -fstack-protector -fno-strict-aliasing -O2 -pipe -fstack-protector -fno-strict-aliasing -fPIC -D_GNU_SOURCE -DFCITX_HAVE_CONFIG_H -fvisibility=hidden -o CMakeFiles/qtim-fcitx.dir/qtkey.cpp.o -c /wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6/src/frontend/qt/qtkey.cpp /wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6/src/frontend/qt/qtkey.cpp:31:52: error: expected ';' at end of declaration static std::unordered_map<uint32_t, int> keyTbl{ ^ ; /wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6/src/frontend/qt/qtkey.cpp:344:5: warning: 'auto' type specifier is a C++11 extension [-Wc++11-extensions] auto iter = KeyTbl().find(key); ^ 1 warning and 1 error generated. *** [src/frontend/qt/CMakeFiles/qtim-fcitx.dir/qtkey.cpp.o] Error code 1 make[4]: stopped in /wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6 1 error make[4]: stopped in /wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6 *** [src/frontend/qt/CMakeFiles/qtim-fcitx.dir/all] Error code 2 make[3]: stopped in /wrkdirs/usr/ports/chinese/fcitx/work/fcitx-4.2.9.6
Sorry for my mistake. I have attached new one. It passed my poudriere.(In reply to Wen Heping from comment #3)
Created attachment 197855 [details] Update chinese/fcitx to 4.2.9.6, 2nd patch
The build failed on FreeBSD 10.4 i386. wen
Created attachment 198706 [details] Update chinese/fcitx-libpinyin to 0.5.3, 3rd I have revised my patch for 10 and 11.
(In reply to Ryo ONODERA from comment #7) Sorry the patch description was wrong, not for fcitx-libpinyin but for fcitx.
A commit references this bug: Author: wen Date: Wed Nov 7 11:48:31 UTC 2018 New revision: 484395 URL: https://svnweb.freebsd.org/changeset/ports/484395 Log: - Update to 4.2.9.6 PR: 231612 Submitted by: ryo@tetera.org Approved by: maintainer Changes: head/chinese/fcitx/Makefile head/chinese/fcitx/distinfo head/chinese/fcitx/files/patch-src_frontend_qt_fcitxwatcher.cpp head/chinese/fcitx/files/patch-tools__gui__quickphrase-editor__CMakeLists.txt head/chinese/fcitx/pkg-plist
It seems that this broke ports depending on fcitx (now bash is needed at runtime?)
(In reply to Antoine Brodin from comment #10) Yes, that sucked http://beefy10.nyi.freebsd.org/data/112i386-default/484426/logs/ja-fcitx-anthy-0.2.1.log The bash is required in the cmake config file of fcitx, so other fcitx modules cannot build :/ In theory, we should add bash to build depends to all fcitx modules :/
(In reply to Antoine Brodin from comment #10) Currently we can add bash as build depends to resolve it. Would you give a list of failed ports caused by the update of fcitx ? wen
Will do in 2 hours.
These ports are failed due to unable to find bash at CMake time in fcitx's cmake config files: korean/fcitx-hangul chinese/fcitx-chewing textproc/fcitx-m17n chinese/fcitx-table-extra chinese/fcitx-sunpinyin chinese/fcitx-cloudpinyin japanese/fcitx-anthy chinese/fcitx-rime I've not received reports on chinese/fcitx-libpinyin, not sure whether it succeed because it depends on QT5, or QT5 is too slow to build...
(In reply to lichray from comment #14) textproc/fcitx-table-other fails too
(In reply to Antoine Brodin from comment #15) Ah, I see, some ports are not maintained by me: https://www.freshports.org/search.php?query=fcitx&search=go&num=10&stype=name&method=match&deleted=excludedeleted&start=1&casesensitivity=caseinsensitive&page=2 fcitx-mozc, fcitx-skk and fcitx-qt5 are worth to check. How do I check the latest build status of a port btw?
(In reply to lichray from comment #16) These 3 ports build well. I found 7 ports failed build and I update the patch: korean/fcitx-hangul chinese/fcitx-chewing textproc/fcitx-m17n chinese/fcitx-table-extra chinese/fcitx-sunpinyin chinese/fcitx-cloudpinyin chinese/fcitx-rime wen
Created attachment 199128 [details] patch to fix some ports broken by the update of fcitx. patch to fix some ports broken by the update of fcitx.
Comment on attachment 199128 [details] patch to fix some ports broken by the update of fcitx. Please commit https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231621 as well.
A commit references this bug: Author: wen Date: Sun Nov 11 11:47:35 UTC 2018 New revision: 484688 URL: https://svnweb.freebsd.org/changeset/ports/484688 Log: - Fix build by adding bash as BUILD_DEPENDS PR: 231612 Submitted by: wen@ Approved by: maintainer Changes: head/chinese/fcitx-chewing/Makefile head/chinese/fcitx-cloudpinyin/Makefile head/chinese/fcitx-rime/Makefile head/chinese/fcitx-sunpinyin/Makefile head/chinese/fcitx-table-extra/Makefile head/korean/fcitx-hangul/Makefile head/textproc/fcitx-m17n/Makefile
Committed