Bug 231730 - sysutils/consolekit2: Add polkit build option
Summary: sysutils/consolekit2: Add polkit build option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
Keywords: easy, feature, needs-qa
: 250544 (view as bug list)
Depends on:
Reported: 2018-09-26 10:37 UTC by Ali Abdallah
Modified: 2020-12-17 16:04 UTC (History)
6 users (show)

See Also:
koobs: merge-quarterly?

Add option for building with/without polkit (1.12 KB, patch)
2018-09-26 10:37 UTC, Ali Abdallah
no flags Details | Diff
updated patch (1.57 KB, patch)
2020-12-16 15:13 UTC, Steve Wills
tcberner: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Abdallah 2018-09-26 10:37:47 UTC
Created attachment 197505 [details]
Add option for building with/without polkit
Comment 1 Ali Abdallah 2020-06-04 08:46:29 UTC
Ping, any way to get this patch included?
Comment 2 Samy Mahmoudi 2020-06-11 12:38:54 UTC

Did you try sending a mail asking commit under maintainer timeout? Here is the pattern I use in such cases:

Address: ports@freebsd.org

[patch] [maintainer timeout, ~20 months] bug 231730 - sysutils/consolekit2: add polkit build option

Dear committer,

Could you please commit the changes associated with the patch file of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231730 ?

Best regards,
Comment 3 Samy Mahmoudi 2020-06-11 12:54:45 UTC
Please also see comment 7 of bug 234919.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2020-06-26 09:01:41 UTC
Hi Ali,

Does the present patch still apply against ports head?
Comment 5 Ali Abdallah 2020-06-26 09:07:08 UTC
(In reply to Kubilay Kocak from comment #4)

I just checked on the 2020Q2 branch and it still applies, last update was on 07 Nov 2019, so it applies also to head.
Comment 6 Tobias C. Berner freebsd_committer 2020-11-15 10:33:01 UTC
@swills, you were looking at similar changes recently, could you take this one?

mfg Tobias
Comment 7 Steve Wills freebsd_committer 2020-12-16 15:13:26 UTC
Created attachment 220622 [details]
updated patch
Comment 8 Steve Wills freebsd_committer 2020-12-16 15:13:41 UTC
*** Bug 250544 has been marked as a duplicate of this bug. ***
Comment 9 Tobias C. Berner freebsd_committer 2020-12-17 15:32:44 UTC
Comment on attachment 220622 [details]
updated patch

Ship it!

mfg Tobias
Comment 10 commit-hook freebsd_committer 2020-12-17 16:03:20 UTC
A commit references this bug:

Author: swills
Date: Thu Dec 17 16:03:06 UTC 2020
New revision: 558300
URL: https://svnweb.freebsd.org/changeset/ports/558300

  sysutils/consolekit2: Add polkit build option

  PR:		231730
  Submitted by:	Ali Abdallah <ali.abdallah@suse.com> (original version)
  Approved by:	desktop@ (tcberner)

Comment 11 Steve Wills freebsd_committer 2020-12-17 16:04:21 UTC
Committed, thanks!