Bug 231769 - www/nextcloud: Fix APCu optionality, add non-ASCII support
Summary: www/nextcloud: Fix APCu optionality, add non-ASCII support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-27 20:36 UTC by Matt
Modified: 2018-09-30 10:23 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brnrd)


Attachments
Correct APCu behavior, add intl option (1.69 KB, patch)
2018-09-27 20:36 UTC, Matt
no flags Details | Diff
Correct APCu behavior, add intl option (1.67 KB, patch)
2018-09-27 20:43 UTC, Matt
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt 2018-09-27 20:36:51 UTC
Created attachment 197556 [details]
Correct APCu behavior, add intl option

The latest version of the port forces APCu to be installed, disregarding the selected value for the APCu option. Fix this so deselecting the option prevents APCu from being installed. 

Additionally, add international (ICU) support for improved sorting.
Comment 1 Matt 2018-09-27 20:43:00 UTC
Created attachment 197557 [details]
Correct APCu behavior, add intl option

Corrected alpha order w/in patch.
Comment 2 Bernard Spil freebsd_committer 2018-09-28 13:37:31 UTC
Hi Matt,

Thanks for the heads-up. Copy-paste mistake.

As far as I know, this is not going to work for the APCU=ON as the OPT_RUN_DEPENDS only works above bsd.port.pre include. I'll test that though. make -VRUN_DEPENDS would show.
Comment 3 commit-hook freebsd_committer 2018-09-28 13:52:44 UTC
A commit references this bug:

Author: brnrd
Date: Fri Sep 28 13:52:13 UTC 2018
New revision: 480860
URL: https://svnweb.freebsd.org/changeset/ports/480860

Log:
  www/nextcloud: Fix APCU option, add INTL

  PR:		231769
  Submitted by:	Matt <fsbruva yahoo com>

Changes:
  head/www/nextcloud/Makefile
Comment 4 Bernard Spil freebsd_committer 2018-09-28 13:53:29 UTC
Again, thanks! Keep 'm coming Matt!
Comment 5 Matt 2018-09-29 14:55:41 UTC
Yep - I never tested with APCu=ON, sorry for that.

Out of curiosity, why didn't https://svnweb.freebsd.org/changeset/ports/480860 bump PORTREVISION?
Comment 6 Bernard Spil freebsd_committer 2018-09-30 10:23:48 UTC
(In reply to Matt from comment #5)
Good question! The APCu change does not lead to a different package with the default options, so this does not warrant a bump.

Looking at the change again, the APCu option doesn't change the package, yet the intl option does change the dependencies. That should does warrant a bump.