Bug 231771 - 24-hour clock time notation in German locales
Summary: 24-hour clock time notation in German locales
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Pankov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-09-27 22:03 UTC by Christoph Schönweiler
Modified: 2020-12-08 07:48 UTC (History)
1 user (show)

See Also:

Attachments
patch file for adapting the locales (1.29 KB, patch)
2018-09-27 22:03 UTC, Christoph Schönweiler 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Schönweiler 2018-09-27 22:03:18 UTC 
Created attachment 197559 [details]
patch file for adapting the locales

In the german speaking countries it is very very uncommon to use the 12-hour clock time notation. So it is a bit vexing that for example the 'w' or 'uptime' command use this format to display times.

The 'w' command has a switch wheter to use the 12-hour or 24-hour clock. It is decided on the existence of a valid 12-hour clock format (am/pm) in the users locale. If the definiton is empty, the tool uses the 24-hour clock.

My suggestion is, to remove the three relevant lines in each locale files for Austria and Germany.

A possible patch file for the files "de_AT.UTF-8.src", "de_AT.ISO8859-15.src", "de_DE.UTF-8.src", "de_DE.ISO8859-15.src" of the source directory "share/timedef" is attached.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-11-11 13:42:14 UTC 
A commit references this bug:

Author: yuripv
Date: Sun Nov 11 13:41:33 UTC 2018
New revision: 340354
URL: https://svnweb.freebsd.org/changeset/base/340354

Log:
  Use blank am_pm and t_fmt_ampm for de_AT and de_DE locales as apparently
  they use 24-hour clock notation.  The visible change is that w(1) now
  uses 24-hour clock format as it checks for t_fmt_ampm presence.

  PR:		231771
  Submitted by:	Christoph Sch?nweiler <public2016@hauptsignal.at>
  Reviewed by:	bapt
  Approved by:	kib (mentor, implicit)
  MFC after:	1 month
  Differential Revision:	https://reviews.freebsd.org/D17945

Changes:
  head/share/timedef/de_AT.ISO8859-15.src
  head/share/timedef/de_AT.UTF-8.src
  head/share/timedef/de_DE.ISO8859-15.src
  head/share/timedef/de_DE.UTF-8.src
Comment 2 commit-hook freebsd_committer freebsd_triage 2020-12-08 07:48:06 UTC 
A commit references this bug:

Author: yuripv
Date: Tue Dec  8 07:47:30 UTC 2020
New revision: 368437
URL: https://svnweb.freebsd.org/changeset/base/368437

Log:
  MFC r340354:

  Use blank am_pm and t_fmt_ampm for de_AT and de_DE locales as apparently
  they use 24-hour clock notation.  The visible change is that w(1) now
  uses 24-hour clock format as it checks for t_fmt_ampm presence.

  PR:		231771
  Submitted by:	Christoph Sch?nweiler <public2016@hauptsignal.at>

Changes:
_U  stable/12/
  stable/12/share/timedef/de_AT.ISO8859-15.src
  stable/12/share/timedef/de_AT.UTF-8.src
  stable/12/share/timedef/de_DE.ISO8859-15.src
  stable/12/share/timedef/de_DE.UTF-8.src