Bug 231789 - sysutils/cbsd: fix build on mips, mips64, powerpc64
Summary: sysutils/cbsd: fix build on mips, mips64, powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-28 16:20 UTC by Piotr Kubaj
Modified: 2018-10-01 14:23 UTC (History)
3 users (show)

See Also:
olevole: maintainer-feedback+


Attachments
patch (4.11 KB, patch)
2018-09-28 16:20 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2018-09-28 16:20:36 UTC
Created attachment 197576 [details]
patch

This port unconditionally links against libc++. This needs to be removed to build on architectures that don't have libc++.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 olevole 2018-09-28 19:01:22 UTC
(In reply to Piotr Kubaj from comment #0)
Thank you. I will fix this in upstrem if there are not any issue for some time.
Unfortunately I can not remember why the link was needed.
Comment 2 olevole 2018-09-28 19:01:34 UTC
Please commit this
Comment 3 Mateusz Piotrowski freebsd_committer 2018-09-28 21:04:47 UTC
I'll take it.
Comment 4 Mateusz Piotrowski freebsd_committer 2018-09-28 21:10:07 UTC
Differential revision: https://reviews.freebsd.org/D17352
Comment 5 commit-hook freebsd_committer 2018-10-01 14:23:02 UTC
A commit references this bug:

Author: 0mp
Date: Mon Oct  1 14:22:38 UTC 2018
New revision: 481034
URL: https://svnweb.freebsd.org/changeset/ports/481034

Log:
  sysutils/cbsd: Fix build on mips, mips64, powerpc64.

  This port unconditionally links against libc++. This needs to be removed
  to build on architectures that don't have libc++.

  PR:		231789
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>
  Approved by:	olevole@olevole.ru (maintainer), mat (mentor)
  Sponsored by:	IntegriCloud (hardware)
  Differential Revision:	https://reviews.freebsd.org/D17352

Changes:
  head/sysutils/cbsd/Makefile
  head/sysutils/cbsd/files/patch-Makefile
  head/sysutils/cbsd/files/patch-bin_cbsdsh_Makefile
  head/sysutils/cbsd/files/patch-sudoexec_initenv
Comment 6 Mateusz Piotrowski freebsd_committer 2018-10-01 14:23:26 UTC
Committed, thanks!