Bug 231814 - comms/owfs: Update to 3.2p3
Summary: comms/owfs: Update to 3.2p3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-30 08:18 UTC by Oleg Sidorkin
Modified: 2018-10-31 11:17 UTC (History)
1 user (show)

See Also:
johan: maintainer-feedback+


Attachments
owfs 3.1p1 -> 3.2p2 update patch (12.53 KB, patch)
2018-09-30 08:18 UTC, Oleg Sidorkin
no flags Details | Diff
owfs 3.1p1 -> 3.2p3 update patch (4.94 KB, patch)
2018-10-04 22:33 UTC, Oleg Sidorkin
no flags Details | Diff
owfs 3.1p1 -> 3.2p3 update patch with github only mastersite (5.03 KB, patch)
2018-10-05 21:20 UTC, Oleg Sidorkin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sidorkin 2018-09-30 08:18:53 UTC
Created attachment 197615 [details]
owfs 3.1p1 -> 3.2p2 update patch

The proposed patch is in attachment.

Added explicit options for libftdi and avahi-app so we can track dependencies. Also some patching was required to pass avahi include paths to some modules so avahi headers could be found.
Comment 1 Johan Ström 2018-10-03 21:08:47 UTC
Hi,

thanks for your interest and submission! Actually, most of those changes where already in GIT, but a new release was quite overdue... So, this pushed me to do the 3.2p3 release, with all of those changes incorporated (including the swig/python fix you had, which was NOT in git).

Could you please update the patch to use 3.2p3 instead, and see if any further changes are required? If not, I can give it a try but a bit short on time to do it right now.

Thanks
Comment 2 Oleg Sidorkin 2018-10-04 22:33:04 UTC
Created attachment 197795 [details]
owfs 3.1p1 -> 3.2p3 update patch
Comment 3 Oleg Sidorkin 2018-10-04 22:38:48 UTC
Here is updated patch:

1) Obsolete patches removed
2) github master site added after SF ones (USE_GITHUB flag seems to build wrong links)
3) reordered Makefile entries a bit to make portlint happy
Comment 4 Johan Ström 2018-10-05 20:55:06 UTC
Comment on attachment 197795 [details]
owfs 3.1p1 -> 3.2p3 update patch

Thanks, OWFS specific stuff looks good to me, but I think current MASTER_SITES will not be approved by porters.

First of all, remove sourceforge, the project have left Sourceforge in favour of Github, and further releases won't show up there.

Second, in bsd.sites.mk there is a DEV_WARNING about using github.com in MASTER_SITES, so I suspect this will be problematic?

Not sure how to exactly use it, but the following seems to work with the current port: 

  USE_GITHUB=yes
  GH_TAGNAME=v${DISTVERSION}

Although it doesn't download the release tar.gz but rather tar.gz snapshot from the repo..  The distfile gets namde owfs-owfs-3.1p1-v3.1p1_GH0.tar.gz and putting that in distinfo seems to build fine...

Not sure whats most appropriate, perhaps some port manager can aid with assistance here?
Will mark the patch as maint approved and we might get some input!
Comment 5 Oleg Sidorkin 2018-10-05 21:10:43 UTC
(In reply to Johan Ström from comment #4)
I saw this in other ports, so it seems to be fine. Since SF mirror is gone, there is no more distfile name troubles.
Comment 6 Oleg Sidorkin 2018-10-05 21:20:15 UTC
Created attachment 197819 [details]
owfs 3.1p1 -> 3.2p3 update patch with github only mastersite
Comment 7 Johan Ström 2018-10-06 05:31:05 UTC
Ah, great! Good from me!
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-10-31 06:25:37 UTC
A commit references this bug:

Author: wen
Date: Wed Oct 31 06:24:58 UTC 2018
New revision: 483552
URL: https://svnweb.freebsd.org/changeset/ports/483552

Log:
  - Update to 3.2p3

  PR:		231814
  Submitted by:	osidorkin@gmail.com
  Approved by:	maintainer

Changes:
  head/comms/owfs/Makefile
  head/comms/owfs/Makefile.options
  head/comms/owfs/distinfo
  head/comms/owfs/pkg-plist