Created attachment 198715 [details]
RC2 test patch

RC2 update, RUST is no longer experimental, but remains optional for now.

Created attachment 199207 [details]
final 4.1 update

Final patch attached, release notes via:

https://suricata-ids.org/2018/11/06/suricata-4-1-released/

Quarterly branch should receive only the 4.0.6 update (currently at 4.0.5)

RUST option stays off for now, depends on user feedback to be enabled by default on selective architectures in the future.


Thanks,
Franco

Thanks for great work! I have a little question about 4.1. From your messages in this thread, it looks like 4.1 port has been already released, but I only see 4.0.6 in the ports tree. I have installed suricata 4.1 from the git repo, but I would rather do it in the regular way. Also, after installing 4.1, I do not see suricata-update anywhere on my system.

Thanks again.

4.1 is not yet in FreeBSD ports.

suricata-update is a separate source code repository so it would need a separate port maybe or be included. Not sure what's more practical.

Comment 5 commit-hook 2018-12-09 01:31:56 UTC

A commit references this bug:

Author: swills
Date: Sun Dec  9 01:31:31 UTC 2018
New revision: 487007
URL: https://svnweb.freebsd.org/changeset/ports/487007

Log:
  security/suricata: update to 4.1

  PR:		231839
  Submitted by:	Franco Fichtner <franco@opnsense.org> (maintainer)

Changes:
  head/security/suricata/Makefile
  head/security/suricata/distinfo
  head/security/suricata/pkg-plist

Comment 6 Steve Wills 2018-12-09 01:32:59 UTC

Committed, thanks! Sorry it took so long.

No worries, thanks for committing <3

Comment 8 Antoine Brodin 2018-12-09 09:15:25 UTC

There is a problem with default options:

- PRELUDE on by default,  while it's useless for almost everyone and off by default upstream

- RUST is off by default while it's on by default upstream and it's one of the major new features in 4.1

The plist is wrong when python is turned on by the way.

Comment 9 Steve Wills 2018-12-09 18:11:32 UTC

(In reply to Antoine Brodin from comment #8)
Logs for the python issue would be helpful.

I'll take a closer look tomorrow. I'm not against removing PRELUDE from the defaults. For RUST the choice was deliberate for the time being as it adds a large build dependency for manual port builders. The new option is there to test and provide feedback for eventual inclusion so that it provides a noticeable feature boost compared to the build wait time. :)

PS: I feel reopening this ticket while not being in CC is a bit counter-productive.

Comment 12 Antoine Brodin 2018-12-09 20:03:17 UTC

(In reply to Franco Fichtner from comment #10)
Default options are for the build cluster, invidivual port builders can use custom options.

Failure log with SC option on:

https://pastebin.com/raw/2Eg3fUR1

Comment 13 commit-hook 2018-12-09 20:19:34 UTC

A commit references this bug:

Author: swills
Date: Sun Dec  9 20:18:32 UTC 2018
New revision: 487081
URL: https://svnweb.freebsd.org/changeset/ports/487081

Log:
  security/suricata: Fix plist with SC option on

  PR:		231839
  Reported by:	antoine

Changes:
  head/security/suricata/pkg-plist

Thanks for the quick fix... but now suricata-update has been pulled in without testing and it's missing a dependency. I'll have a fix ready in a bit.

Created attachment 200000 [details]
PYHTON option, default changes

How about this to address all requests?

o Rename SC to PYTHON to reflect the new state of the option (includes suricata-update)
o Remove PRELUDE from defaults (as requested by Antoine)
o Add PYTHON to defaults (as requested by Serge)
o Add RUST to defaults (as requested by Antoine)


Cheers,
Franco

Comment 16 commit-hook 2018-12-10 16:05:52 UTC

A commit references this bug:

Author: swills
Date: Mon Dec 10 16:04:50 UTC 2018
New revision: 487180
URL: https://svnweb.freebsd.org/changeset/ports/487180

Log:
  security/suricata: multiple changes to previous update

  * Rename SC to PYTHON to reflect the new state of the option
  * Remove PRELUDE from defaults
  * Add PYTHON to defaults
  * Add RUST to defaults

  PR:		231839
  Submitted by:	Franco Fichtner <franco@opnsense.org> (maintainer)

Changes:
  head/security/suricata/Makefile
  head/security/suricata/pkg-plist

Thanks again!