Bug 231987 - x11-wm/hs-xmonad: Update to 0.15
Summary: x11-wm/hs-xmonad: Update to 0.15
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gleb Popov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-05 22:23 UTC by Kevin Zheng
Modified: 2018-10-06 10:12 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+


Attachments
Patch for xmonad (1.24 KB, patch)
2018-10-05 22:23 UTC, Kevin Zheng
no flags Details | Diff
Patch for xmonad-contrib (1.10 KB, patch)
2018-10-05 22:23 UTC, Kevin Zheng
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2018-10-05 22:23:05 UTC
Created attachment 197822 [details]
Patch for xmonad

cabal no longer installs xmonad.hs; install it ourselves.
Comment 1 Kevin Zheng 2018-10-05 22:23:44 UTC
Created attachment 197823 [details]
Patch for xmonad-contrib

Also update x11-wm/hs-xmonad-contrib
Comment 2 Tobias C. Berner freebsd_committer 2018-10-05 22:41:09 UTC
Moin moin 

Why did you drop 

FLAGS_DISABLE=	testing



mfg Tobias
Comment 3 Kevin Zheng 2018-10-05 22:51:20 UTC
(In reply to Tobias C. Berner from comment #2)
According to hackage, it is default disabled and set manually (i.e. will never be automatically set). So, it's redundant.

I'm not sure what the convention here is for the FLAGS. There is also a generatemanpage FLAG that we don't explicitly disable that is disabled by default.
Comment 4 Tobias C. Berner freebsd_committer 2018-10-05 22:57:56 UTC
(In reply to Kevin Zheng from comment #3)
Sounds reasonable. It seems like it was added for 0.11.4. Possibly it was shortly on by default there.
Comment 5 commit-hook freebsd_committer 2018-10-06 10:09:48 UTC
A commit references this bug:

Author: arrowd
Date: Sat Oct  6 10:09:15 UTC 2018
New revision: 481361
URL: https://svnweb.freebsd.org/changeset/ports/481361

Log:
  x11-wm/hs-xmonad and x11-wm/hs-xmonad-contrib: Update to 0.15.

  PR:		231987
  Submitted by:	Kevin Zheng <kevinz5000@gmail.com>
  Approved by:	tcberner (mentor)

Changes:
  head/x11-wm/hs-xmonad/Makefile
  head/x11-wm/hs-xmonad/distinfo
  head/x11-wm/hs-xmonad-contrib/Makefile
  head/x11-wm/hs-xmonad-contrib/distinfo
Comment 6 Gleb Popov freebsd_committer 2018-10-06 10:12:49 UTC
Thanks for your patch.