Bug 232084 - bhyve crashes with SIGSEGV under NetBSD guest and xhci
Summary: bhyve crashes with SIGSEGV under NetBSD guest and xhci
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Some People
Assignee: Peter Grehan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-08 19:53 UTC by Oleg Ginzburg
Modified: 2020-07-10 18:24 UTC (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Ginzburg 2018-10-08 19:53:48 UTC
Hello. NetBSD works fine in bhyve, except for the case when the bhyve
emulates eXtensible Host Controller Interface (xHCI) USB controller. (
-s 30,xhci,tablet )

LLDB output upon bhyve crash (guest screen: https://pasteboard.co/HFAqTOk.png ):

https://github.com/freebsd/freebsd/blob/ebeb3285f598d6c1214c49598c951493d09e1067/usr.sbin/bhyve/pci_xhci.c#L735

Process 57083 stopped
* thread #20, name = 'vcpu 0', stop reason = signal SIGSEGV: invalid
address (fault address: 0x0)
    frame #0: 0x00000000002587d8
bhyve`pci_xhci_insert_event(sc=0x00000008010a5100,
evtrb=0x00007fffddbeba78, do_intr=0) at pci_xhci.c:735
   732          rts = &sc->rtsregs;
   733
   734          erdp = rts->intrreg.erdp & ~0xF;
-> 735          erdp_idx = (erdp -
rts->erstba_p[rts->er_deq_seg].qwEvrsTablePtr) /
   736                     sizeof(struct xhci_trb);
   737
   738          DPRINTF(("pci_xhci: insert event 0[%lx] 2[%x] 3[%x]\r\n"
(lldb) frame variable erdp_idx
(int) erdp_idx = 0


in all likelihood, the problem in the rts->erstba_p structure because
when I commenting 735 line ( erdp_idx is used only in DPRINTF debug
output ) the next stop when working with this structure again, e.g:

Process 58354 stopped
* thread #20, name = 'vcpu 0', stop reason = signal SIGSEGV: invalid
address (fault address: 0x8)
    frame #0: 0x0000000000258881
bhyve`pci_xhci_insert_event(sc=0x00000008010a5100,
evtrb=0x00007fffddbeba78, do_intr=0) at pci_xhci.c:750
   747          evtrbptr = &rts->erst_p[rts->er_enq_idx];
   748
   749          /* TODO: multi-segment table */
-> 750          if (rts->er_events_cnt >= rts->erstba_p->dwEvrsTableSize) {
   751                  DPRINTF(("pci_xhci[%d] cannot insert event;
ring full\r\n",
   752                           __LINE__));
   753                  err = XHCI_TRB_ERROR_EV_RING_FULL;


What can I do to find out the reasons for this behavior? Thanks!
Comment 1 Oleg Ginzburg 2019-02-06 15:31:43 UTC
one more comment about the problem: https://lists.freebsd.org/pipermail/freebsd-virtualization/2019-February/007159.html
Comment 2 Mark Johnston freebsd_committer freebsd_triage 2020-07-10 18:16:27 UTC
Fixed in head by r363070.
Comment 3 Oleg Ginzburg 2020-07-10 18:24:06 UTC
Thx, closed