Bug 232086 - net/tcpflow: fix build with GCC-based architectures
Summary: net/tcpflow: fix build with GCC-based architectures
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Antoine Brodin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-08 20:52 UTC by Piotr Kubaj
Modified: 2018-10-28 09:53 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (antoine)

Attachments
patch (1.17 KB, patch)
2018-10-08 20:52 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-08 20:52:12 UTC 
Created attachment 197929 [details]
patch

This port requires USES=compiler:c11 to build on architectures using GCC in base.

It also requires including sys/param.h in src/wifipcap/wifipcap.cpp.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2018-10-09 19:34:01 UTC 
Please send the patch upstream,  I don't want to keeps patches around for archs I can't test on.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-09 20:37:02 UTC 
(In reply to Antoine Brodin from comment #1)
You don't need to test it on tier 2 architectures. You can just build with GCC on amd64 using by defining USE_GCC=yes.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2018-10-09 20:38:38 UTC 
Please send the patch upstream,  I don't want to keep patches around.
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-09 20:49:58 UTC 
https://github.com/simsong/tcpflow/pull/193
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2018-10-28 09:53:01 UTC 
This will be picked up when this goes upstream.