Bug 232087 - sysutils/smart: fix build with mips, mips64, powerpc64
Summary: sysutils/smart: fix build with mips, mips64, powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joseph Mingrone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-08 21:20 UTC by Piotr Kubaj
Modified: 2018-10-27 23:27 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (jrm)


Attachments
patch (1.63 KB, patch)
2018-10-08 21:20 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2018-10-08 21:20:53 UTC
Created attachment 197930 [details]
patch

GCC treats const int as a variable and forbids creating arrays of a size of such variable.

Switch from const int to define to fix it.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 chuck 2018-10-09 20:53:01 UTC
Hi

Thank you for reporting this. I'm the upstream author and just ran into this bug as well. There should be a slightly different fix in the next day or so.
Comment 2 chuck 2018-10-09 21:01:18 UTC
Upstream tracking https://bitbucket.org/ctuffli/smart/issues/9
Comment 3 Chuck Tuffli freebsd_committer 2018-10-12 13:53:51 UTC
Updated in version 0.0.11
Comment 4 commit-hook freebsd_committer 2018-10-12 22:19:59 UTC
A commit references this bug:

Author: jrm
Date: Fri Oct 12 22:19:31 UTC 2018
New revision: 481943
URL: https://svnweb.freebsd.org/changeset/ports/481943

Log:
  sysutils/smart: Update to 0.0.11 and fix build on mips(64), powerpc

  PR:		232087
  Reported by:	pkubaj@anongoth.pl

Changes:
  head/sysutils/smart/Makefile
  head/sysutils/smart/distinfo
Comment 5 Joseph Mingrone freebsd_committer 2018-10-12 22:22:25 UTC
Piotr, could you confirm that this works on mips, mips64, and powerpc64?
Comment 6 Joseph Mingrone freebsd_committer 2018-10-27 23:14:30 UTC
I do not have any of the hardware listed here to confirm the fix.  Please re-open if it's still an issue.
Comment 7 Piotr Kubaj freebsd_committer 2018-10-27 23:27:13 UTC
(In reply to Joseph Mingrone from comment #6)
Sorry about that, I forgot about this bug!

Yes, it works on powerpc64.