Bug 232148 - NVME and loader src.conf knobs missing src.conf(5) descriptions
Summary: NVME and loader src.conf knobs missing src.conf(5) descriptions
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Warner Losh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-10 12:51 UTC by Ed Maste
Modified: 2019-03-10 15:25 UTC (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer 2018-10-10 12:51:06 UTC 
Running makeman in tools/build/options reports a number of missing descriptions:

no description found for WITH_LOADER_FORCE_LE, skipping
no description found for WITH_LOADER_GELI, skipping
no description found for WITHOUT_LOADER_LUA, skipping
no description found for WITHOUT_NVME, skipping
no description found for WITH_NVME, skipping
Comment 1 Warner Losh freebsd_committer 2018-10-10 13:47:48 UTC 
I'll take care of this...
Comment 2 Greg V 2019-03-10 15:23:28 UTC 
Does WITH_NVME/WITHOUT_NVME do anything at all?

The only mention of WITH_NVME in the code is in camcontrol.c and it's defined in the makefile in CFLAGS as -DWITH_NVME.

Looks like nvme support is determined by kernel configs — adding 'device nvme' and 'device nvd' to sys/arm64/conf/GENERIC was enough to enable the drivers on aarch64…
Comment 3 Kyle Evans freebsd_committer 2019-03-10 15:25:52 UTC 
(In reply to Greg V from comment #2)

Sure, see [0]; WITH/WITHOUT typically get converted to MK_ knob values and are checked as such.

[0] http://src.illumos.org/source/search?q=MK_NVME&defs=&refs=&path=&hist=&project=freebsd-head