Bug 232179 - sysutils/py-salt: Add missing dependency
Summary: sysutils/py-salt: Add missing dependency
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-10-11 15:26 UTC by Mathieu Arnold
Modified: 2018-11-18 03:49 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (christer.edwards)
koobs: merge-quarterly?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2018-10-11 15:26:42 UTC
Hi,

Today I was trying to fix some long running jobs, and it seems it needs sysutils/py-psutil:

saltutil.signal job called, but psutil is not installed. Install psutil to ensure more reliable and accurate PID management.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-10-15 10:12:50 UTC
Upstream module docs also mention an additional (though optional?) dependency:

https://docs.saltstack.com/en/latest/ref/modules/all/salt.modules.ps.html
Comment 2 Christer Edwards 2018-10-18 16:40:20 UTC
Hi. 

Sorry to hear you had trouble with the port. The difficulty with a port like py-salt is that it potentially has 400 optional dependencies, one for each execution module. Unfortunately, it isn't feasible to include all of the optional ports in the base package. It would be enormous.

My preference is to keep the base py-salt package as small as it can be for essential functionality. Some execution modules will require additional Python libraries, and those need to be resolved locally by the end user.
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2018-10-25 14:08:23 UTC
This is not about an obscure module that nobody uses, adding this dependency fixes a real problem with salt's job scheduling itself.
Comment 4 Christer Edwards 2018-11-17 17:20:53 UTC
I have submitted #233275 to add this missing dependency.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2018-11-18 03:49:38 UTC
Superseded by bug 233275