Bug 232216 - sysutils/dmg2img: Fix OpenSSL build
Summary: sysutils/dmg2img: Fix OpenSSL build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL: https://sources.debian.org/patches/dm...
Keywords:
Depends on:
Blocks: 231931
  Show dependency tree / graph
 
Reported: 2018-10-13 04:22 UTC by Nathan
Modified: 2018-10-20 08:16 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
OpenSSL patch (7.32 KB, patch)
2018-10-13 04:22 UTC, Nathan 		ndowens04: maintainer-approval? (sunpoet)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan 2018-10-13 04:22:16 UTC 
Created attachment 198086 [details]
OpenSSL patch

sysutils/dmg2img: Fix OpenSSL build
 
 PR:             231931
 Submitted by:   Nathan <ndowens@yahoo.com>
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-10-13 06:59:07 UTC 
This seems ok-ish after a quick read.  The code could use some NULL checks
to check if the *_new() functions actually returned something usable though...
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-10-20 08:16:51 UTC 
Thanks for submitting a patch. But I think this patch is incomplete. At least it cannot be applied directly. Otherwise, it would make the port fails to build with base OpenSSL of FreeBSD 11 (1.0.2*).

I've committed a patch in r482053. Please reopen this PR if it does not work. Thanks!