Bug 232236 - mail/dovecot: dependency on libsodium picked up spuriously (fix included)
Summary: mail/dovecot: dependency on libsodium picked up spuriously (fix included)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-14 10:20 UTC by Martin Birgmeier
Modified: 2018-10-14 13:31 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ler)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2018-10-14 10:20:31 UTC
Scenario:
- security/libsodium installed
- mail/dovecot being rebuilt

Result:
- dovecot includes a dependency on libsodium, but this is not recorded in the package dependencies

Expected result:
- dependencies recorded in the package should match reality

Fix:
- include "--without-sodium" in CONFIGURE_ARGS
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-10-14 11:23:07 UTC
Cannot reproduce the error. Maybe, it is a portmaster error. Portmaster was updated yesterday, did you have the recent version?  - 3.19.16.
Add maintainer of portmaster to CC-List.
Comment 2 Martin Birgmeier 2018-10-14 11:49:53 UTC
How to reproduce:
- Install libsodium
- Build dovecot using portmaster
- Observe that dovecot's dependency list ('pkg query %dn-%dv') does not include libsodium
- Uninstall libsodium (does not require uninstallation of dovecot because of missing recording of dependency)
- Observe that dovecot's library dependencies are not satisfied ('pkg check -da')
Comment 3 Martin Birgmeier 2018-10-14 11:52:59 UTC
Also, during the configure stage of the build one can see that a dependency on libsodium is picked up.
Comment 4 Walter Schwarzenfeld freebsd_triage 2018-10-14 12:15:18 UTC
Sorry, pkg check -da shows nothing.
Comment 5 Walter Schwarzenfeld freebsd_triage 2018-10-14 12:30:26 UTC
sorry, forgot to deinstall libsodium.

pkg info dovecot
Shared Libs required:
	libbz2.so.1
	libcrypto.so.43
	libmysqlclient.so.18
	libssl.so.45
=>	libsodium.so.23
Comment 6 Walter Schwarzenfeld freebsd_triage 2018-10-14 13:03:54 UTC
and
readelf -d /usr/local/libexec/dovecot/auth|grep NEED
 0x0000000000000001 (NEEDED)             Shared library: [libstats_auth.so]
 0x0000000000000001 (NEEDED)             Shared library: [libdovecot.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libcrypt.so.5]
 0x0000000000000001 (NEEDED)             Shared library: [libpam.so.5]
=> 0x0000000000000001 (NEEDED)             Shared library: [libsodium.so.23]
 0x0000000000000001 (NEEDED)             Shared library: [libmysqlclient.so.18]
 0x0000000000000001 (NEEDED)             Shared library: [libz.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [libm.so.5]
 0x0000000000000001 (NEEDED)             Shared library: [libexecinfo.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libssl.so.45]
 0x0000000000000001 (NEEDED)             Shared library: [libcrypto.so.43]
 0x0000000000000001 (NEEDED)             Shared library: [libthr.so.3]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.7]
 0x000000006ffffffe (VERNEED)            0xb050
 0x000000006fffffff (VERNEEDNUM)         1
Comment 7 commit-hook freebsd_committer 2018-10-14 13:30:46 UTC
A commit references this bug:

Author: ler
Date: Sun Oct 14 13:30:40 UTC 2018
New revision: 482041
URL: https://svnweb.freebsd.org/changeset/ports/482041

Log:
  mail/dovecot: don't pick up libsodium if installed.

  PR:		232236
  Submitted by:	d8zNeCFG@aon.at

Changes:
  head/mail/dovecot/Makefile
Comment 8 Larry Rosenman freebsd_committer 2018-10-14 13:31:26 UTC
Committed, Thanks.