Bug 232237 - net-p2p/libtorrent: includes spurious dependency on devel/cppunit
Summary: net-p2p/libtorrent: includes spurious dependency on devel/cppunit
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Danilo G. Baio
URL: https://github.com/rakshasa/libtorren...
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2018-10-14 10:42 UTC by Martin Birgmeier
Modified: 2019-08-16 03:45 UTC (History)
3 users (show)

See Also:


Attachments
svn-diff-libtorrent_cppunit (960 bytes, patch)
2019-08-16 02:52 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-libtorrent_v2 (744 bytes, patch)
2019-08-16 02:57 UTC, Walter Schwarzenfeld
no flags Details | Diff
svn-diff-libtorrent_cppunit_v3 (1.81 KB, patch)
2019-08-16 03:45 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2018-10-14 10:42:14 UTC
Scenario:
- devel/cppunit installed
- net-p2p/libtorrent being rebuilt using portmaster

Result:
- libtorrent picks up a dependency on cppunit which is not recorded in the package

Expected result:
- libtorrent should not pick up a dependency on cppunit even if the latter is installed
Comment 1 Walter Schwarzenfeld freebsd_triage 2018-10-14 11:18:36 UTC
Cannot reproduce the error. Maybe, it is a portmaster error. Portmaster was updated yesterday, did you have the recent version?  - 3.19.16.
Add maintainer of portmaster to CC-List.
Comment 2 Danilo G. Baio freebsd_committer 2018-11-17 17:15:38 UTC
Hi Martin.

Thanks for your report, I can confirm this.

I've opened an issue on Github: https://github.com/rakshasa/libtorrent/issues/182

I couldn't find a way to disable cppunit check without a patch in configure.

Let's wait for a feedback from the author, maybe will be possible to include an option to enable tests (check target) if the user wants it.

But for now, cppunit is not needed, it is just used for tests (check target).

Regards.
Comment 3 Walter Schwarzenfeld freebsd_triage 2019-08-16 02:52:30 UTC
Created attachment 206605 [details]
svn-diff-libtorrent_cppunit
Comment 4 Walter Schwarzenfeld freebsd_triage 2019-08-16 02:55:10 UTC
Built with clang80.

/usr/local/lib/libtorrent.so:
	libz.so.6 => /lib/libz.so.6 (0x8012f8000)
	libcrypto.so.45 => /usr/local/lib/libcrypto.so.45 (0x801510000)
	libc++.so.1 => /usr/lib/libc++.so.1 (0x8018fc000)
	libcxxrt.so.1 => /lib/libcxxrt.so.1 (0x801bca000)
	libm.so.5 => /lib/libm.so.5 (0x801de9000)
	libc.so.7 => /lib/libc.so.7 (0x800823000)
	libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x802016000)
	libthr.so.3 => /lib/libthr.so.3 (0x802225000)
Comment 5 Walter Schwarzenfeld freebsd_triage 2019-08-16 02:57:47 UTC
Created attachment 206607 [details]
svn-diff-libtorrent_v2

Forgot to remove one line I had for test.
Comment 6 Walter Schwarzenfeld freebsd_triage 2019-08-16 03:45:46 UTC
Created attachment 206608 [details]
svn-diff-libtorrent_cppunit_v3

Forgot to add the patch-configure.ac to svn.