Bug 232325 - games/spacejunk: fix build with GCC-based architectures
Summary: games/spacejunk: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-16 14:50 UTC by Piotr Kubaj
Modified: 2018-10-28 19:36 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)


Attachments
patch (424 bytes, patch)
2018-10-16 14:50 UTC, Piotr Kubaj
no flags Details | Diff
v2 (1.56 KB, patch)
2018-10-16 15:36 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-16 14:50:46 UTC
Created attachment 198215 [details]
patch

-Wno-c++11-narrowing is unavailable in base GCC.

It's enough to add USE_CXXSTD=c++98, this makes this port build with both base GCC and LLVM.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-16 15:36:32 UTC
Created attachment 198220 [details]
v2

Small correction, additional fix is necessary.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-10-28 19:36:15 UTC
A commit references this bug:

Author: linimon
Date: Sun Oct 28 19:35:20 UTC 2018
New revision: 483328
URL: https://svnweb.freebsd.org/changeset/ports/483328

Log:
  Fix build on powerpc64.

  PR:		232325
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/games/spacejunk/Makefile
  head/games/spacejunk/files/patch-src_pmask.h