Bug 232482 - [PATCH] net/phpldapadmin: support for php72+
Summary: [PATCH] net/phpldapadmin: support for php72+
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthew Seaman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-20 17:24 UTC by Krzysztof
Modified: 2018-10-21 22:55 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (matthew)


Attachments
phpldapadmin php72 support (4.17 KB, patch)
2018-10-20 17:24 UTC, Krzysztof
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof 2018-10-20 17:24:41 UTC
Created attachment 198404 [details]
phpldapadmin php72 support

Hello,

phpldapadmin is not work correctly with php72. It shows error (inside browser) about deprecated functions.

After some researching I've made a patch which make php72 happy. Also PLA is working without problems.

I've tested this patch with my poudriere. You can check logs:
http://pkg.bsdserwis.com/pkg/data/11x64-testing-php71/2018-10-20_16h43m33s/logs/phpldapadmin-1.2.3_9,1.log

http://pkg.bsdserwis.com/pkg/data/11x64-testing-php72/2018-10-20_16h57m34s/logs/phpldapadmin-1.2.3_9,1.log

Also this patch does not brake PLA with php71 (I've tested it with one of my servers).

So I hope this patch will be applied quickly :-)))
Comment 1 Matthew Seaman freebsd_committer freebsd_triage 2018-10-20 18:22:52 UTC
Thank you very much for the patch.  I'm just test building it now.

Would you like to take over maintainership for net/phpldapadmin?  I no longer use it myself.
Comment 2 Krzysztof 2018-10-20 19:13:47 UTC
Yes, I can take maintainership.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-21 22:55:00 UTC
A commit references this bug:

Author: matthew
Date: Sun Oct 21 22:53:57 UTC 2018
New revision: 482726
URL: https://svnweb.freebsd.org/changeset/ports/482726

Log:
  Update files/patch-lib__functions.php to add php72 compatibility (1)

  Hand over maintainership to submitter

  Flavourize

  Mark as ignored with php73

  Use PLIST_FILES instead of pkg-plist-chunk.  Consequently, just
  substitute in the value of ${WWWDIR_REL} directly, rather than playing
  around with %%WWWDIR%% sed-tokens.

  Swap around the ordering a bit to pacify portlint

  PR:		232482
  Submitted by:	ports@bsdserwis.com (1)

Changes:
  head/net/phpldapadmin/Makefile
  head/net/phpldapadmin/files/patch-lib__functions.php
  head/net/phpldapadmin/pkg-plist-chunk
Comment 4 Matthew Seaman freebsd_committer freebsd_triage 2018-10-21 22:55:44 UTC
Committed, thanks!