Created attachment 198404 [details] phpldapadmin php72 support Hello, phpldapadmin is not work correctly with php72. It shows error (inside browser) about deprecated functions. After some researching I've made a patch which make php72 happy. Also PLA is working without problems. I've tested this patch with my poudriere. You can check logs: http://pkg.bsdserwis.com/pkg/data/11x64-testing-php71/2018-10-20_16h43m33s/logs/phpldapadmin-1.2.3_9,1.log http://pkg.bsdserwis.com/pkg/data/11x64-testing-php72/2018-10-20_16h57m34s/logs/phpldapadmin-1.2.3_9,1.log Also this patch does not brake PLA with php71 (I've tested it with one of my servers). So I hope this patch will be applied quickly :-)))
Thank you very much for the patch. I'm just test building it now. Would you like to take over maintainership for net/phpldapadmin? I no longer use it myself.
Yes, I can take maintainership.
A commit references this bug: Author: matthew Date: Sun Oct 21 22:53:57 UTC 2018 New revision: 482726 URL: https://svnweb.freebsd.org/changeset/ports/482726 Log: Update files/patch-lib__functions.php to add php72 compatibility (1) Hand over maintainership to submitter Flavourize Mark as ignored with php73 Use PLIST_FILES instead of pkg-plist-chunk. Consequently, just substitute in the value of ${WWWDIR_REL} directly, rather than playing around with %%WWWDIR%% sed-tokens. Swap around the ordering a bit to pacify portlint PR: 232482 Submitted by: ports@bsdserwis.com (1) Changes: head/net/phpldapadmin/Makefile head/net/phpldapadmin/files/patch-lib__functions.php head/net/phpldapadmin/pkg-plist-chunk
Committed, thanks!