Bug 232541 - net/openbgpd: rc script kills instances in jails
Summary: net/openbgpd: rc script kills instances in jails
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2018-10-22 18:37 UTC by gibheer
Modified: 2018-12-05 19:18 UTC (History)
2 users (show)

See Also:
koobs: merge-quarterly?


Attachments
patch-openbgpdrc (629 bytes, patch)
2018-10-22 18:53 UTC, w.schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gibheer 2018-10-22 18:37:39 UTC
The openbgpd rc script checks for running processes the following function:

check_process()
{
        /bin/pgrep -f 'bgpd: parent.*'
}

When run on the host system with openbgpd instances running in jails, this can lead to killing them too.

To fix the problem, pgrep must be told to only use jail id 0 when searching for processes:

check_process()
{
        /bin/pgrep -j none -f 'bgpd: parent.*'
}

With this, only processes in the jail context are searched and therefore killed.
Comment 1 w.schwarzenfeld freebsd_triage 2018-10-22 18:53:56 UTC
Created attachment 198478 [details]
patch-openbgpdrc
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-10-23 07:30:53 UTC
Assign to maintainer
Comment 3 gibheer 2018-12-05 19:18:15 UTC
Hi,

thank you for the help. Is there any chance to get this merged? I just switched to FreeBSD 12.0-RC3, reinstalled all my ports and ran again into the same issue :(.
Is there anything I can help with to move this forward?