Bug 232577 - x11-toolkits/libdazzle: fix build with GCC-based architectures
Summary: x11-toolkits/libdazzle: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-23 22:44 UTC by Piotr Kubaj
Modified: 2018-11-24 07:21 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
patch (365 bytes, patch)
2018-10-23 22:44 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-23 22:44:55 UTC 
Created attachment 198517 [details]
patch

GCC architectures need USES=compiler:c++11-lang to build this port.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Ting-Wei Lan 2018-10-24 14:01:37 UTC 
libdazzle is written in C, so it is odd for it to require C++11. Did you mean c11 instead?
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-24 14:13:06 UTC 
There are not many ports that use C11, so I actually meant C++11. That said, it doesn't really matter from the perspective of ports infrastructure. Clang in all releases supports both C++11 and C11, GCC 4.2 supports neither C++11 nor C11 :)

If you feel that it's better to put C11, it's not a problem since both will work the same.
Comment 3 Ting-Wei Lan 2018-10-24 14:37:26 UTC 
(In reply to Piotr Kubaj from comment #2)
It is correct that there are more programs using C++11 than C11, but it doesn't mean there is no programs using C11. meson.build file of libdazzle has c_std=gnu11 and I think it suggests it does need C11.
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-24 14:51:48 UTC 
(In reply to Ting-Wei Lan from comment #3)
Hm, now that I see, it seems that the description in #1 is wrong and the patch is ok (contains C11).

Sorry, there's so many of such ports with missing compiler:c++11-lang entry, that I just got used to it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-11-24 07:21:55 UTC 
A commit references this bug:

Author: linimon
Date: Sat Nov 24 07:20:56 UTC 2018
New revision: 485728
URL: https://svnweb.freebsd.org/changeset/ports/485728

Log:
  Add compiler:c11 to USES to fix build with GCC-based architectures.

  PR:		232577
  Submitted by:	Piotr Kubaj
  Reviewed by:	Ting-Wei Lan
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/x11-toolkits/libdazzle/Makefile