Bug 232589 - science/step: fix build with GCC-based architectures
Summary: science/step: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-24 00:35 UTC by Piotr Kubaj
Modified: 2018-10-27 12:03 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+

Attachments
patch (909 bytes, patch)
2018-10-24 00:35 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-24 00:35:59 UTC 
Created attachment 198528 [details]
patch

Add USES=compiler:c++11-lang.

CXXFLAGS+=-Wno-error=return-type is necessary to fix:
In file included from /usr/local/include/eigen3/unsupported/Eigen/IterativeSolvers:36:0,
                 from /tmp/usr/local/poudriere/ports/default/science/step/work/step-18.08.2/stepcore/constraintsolver.cc:24:
/usr/local/include/eigen3/unsupported/Eigen/src/IterativeSolvers/DGMRES.h: In member function 'Eigen::Index Eigen::DGMRES<_MatrixType, _Preconditioner>::set_re
start(Eigen::Index)':
/usr/local/include/eigen3/unsupported/Eigen/src/IterativeSolvers/DGMRES.h:176:63: error: no return statement in function returning non-void [-Werror=return-typ
e]
   Index set_restart(const Index restart) { m_restart=restart; }

I added it only for GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-10-27 11:53:31 UTC 
A commit references this bug:

Author: tcberner
Date: Sat Oct 27 11:51:21 UTC 2018
New revision: 483125
URL: https://svnweb.freebsd.org/changeset/ports/483125

Log:
  Fix build with GCC-based architectures for various kde@ ports.

  - Qt5 required c++11 support.

  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>
  PR:		232726
  PR:		232725
  PR:		232723
  PR:		232722
  PR:		232721
  PR:		232720
  PR:		232719
  PR:		232697
  PR:		232682
  PR:		232669
  PR:		232668
  PR:		232667
  PR:		232666
  PR:		232665
  PR:		232664
  PR:		232662
  PR:		232661
  PR:		232655
  PR:		232654
  PR:		232652
  PR:		232648
  PR:		232647
  PR:		232641
  PR:		232640
  PR:		232638
  PR:		232635
  PR:		232634
  PR:		232632
  PR:		232631
  PR:		232630
  PR:		232629
  PR:		232628
  PR:		232627
  PR:		232625
  PR:		232624
  PR:		232623
  PR:		232614
  PR:		232613
  PR:		232612
  PR:		232611
  PR:		232610
  PR:		232609
  PR:		232607
  PR:		232606
  PR:		232605
  PR:		232604
  PR:		232603
  PR:		232602
  PR:		232597
  PR:		232589
  PR:		232585
  PR:		232584
  PR:		232583
  PR:		232581
  PR:		232580
  PR:		232579
  PR:		232578
  PR:		232576
  PR:		232575
  PR:		232574
  PR:		232573
  PR:		232570

Changes:
  head/archivers/ark/Makefile
  head/astro/marble/Makefile
  head/audio/kmix/Makefile
  head/audio/libkcddb/Makefile
  head/audio/libkcompactdisc/Makefile
  head/deskutils/kcharselect/Makefile
  head/deskutils/keditbookmarks/Makefile
  head/deskutils/kruler/Makefile
  head/devel/cervisia/Makefile
  head/devel/injeqt/files/patch-src_internal_containers.h
  head/devel/kapptemplate/Makefile
  head/devel/kde-dev-utils/Makefile
  head/devel/lokalize/Makefile
  head/devel/okteta/Makefile
  head/editors/kate/Makefile
  head/games/blinken/Makefile
  head/games/khangman/Makefile
  head/games/libkdegames/Makefile
  head/graphics/kamera/Makefile
  head/graphics/kcolorchooser/Makefile
  head/graphics/kdegraphics-mobipocket/Makefile
  head/graphics/kdegraphics-svgpart/Makefile
  head/graphics/kdegraphics-thumbnailers/Makefile
  head/graphics/libkipi/Makefile
  head/graphics/libksane/Makefile
  head/japanese/kiten/Makefile
  head/lang/kturtle/Makefile
  head/math/cantor/Makefile
  head/math/kbruch/Makefile
  head/math/kcalc/Makefile
  head/math/kmplot/Makefile
  head/math/rocs/Makefile
  head/misc/artikulate/Makefile
  head/misc/kgeography/Makefile
  head/misc/klettres/Makefile
  head/misc/libkeduvocdocument/Makefile
  head/multimedia/dragon/Makefile
  head/net/kdenetwork-filesharing/Makefile
  head/net/krdc/Makefile
  head/net-p2p/libktorrent/Makefile
  head/print/print-manager/Makefile
  head/science/step/Makefile
  head/security/kwalletmanager/Makefile
  head/security/libkleo/Makefile
  head/sysutils/filelight/Makefile
  head/sysutils/kcron/Makefile
  head/sysutils/kdebugsettings/Makefile
  head/sysutils/kdf/Makefile
  head/sysutils/kdialog/Makefile
  head/sysutils/kfloppy/Makefile
  head/sysutils/ksystemlog/Makefile
  head/sysutils/plasma5-drkonqi/Makefile
  head/sysutils/qt5-qtdiag/Makefile
  head/sysutils/signon-kwallet-extension/Makefile
  head/textproc/libkomparediff2/Makefile
  head/x11/plasma5-kgamma5/Makefile
  head/x11/plasma5-kscreen/Makefile
  head/x11/sddm/Makefile
  head/x11-clocks/kteatime/Makefile
  head/x11-clocks/ktimer/Makefile
  head/x11-themes/kf5-qqc2-desktop-style/Makefile
  head/x11-toolkits/qt5-gamepad/Makefile
Comment 2 Tobias C. Berner freebsd_committer freebsd_triage 2018-10-27 12:03:13 UTC 
Committed, thanks.