Bug 232750 - devel/protobuf: fix build with GCC-based architectures
Summary: devel/protobuf: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-27 20:40 UTC by Piotr Kubaj
Modified: 2018-10-28 08:30 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
patch (1.14 KB, patch)
2018-10-27 20:40 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2018-10-27 20:40:07 UTC
Created attachment 198695 [details]
patch

js_embed, used to generate well_known_types_embed.cc is linked to base libstdc++, and then fails to run on GCC architectures (the port uses GCC7).

Add CXXFLAGS for js_embed build.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer 2018-10-28 08:07:52 UTC
A commit references this bug:

Author: linimon
Date: Sun Oct 28 08:07:37 UTC 2018
New revision: 483235
URL: https://svnweb.freebsd.org/changeset/ports/483235

Log:
  Fix build on powerpc64.

  While here, pet portlint.

  PR:		232750
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/devel/protobuf/Makefile
  head/devel/protobuf/files/patch-src_Makefile.am
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2018-10-28 08:30:12 UTC
Grabbed and committed.  (This blocks 391 dependencies on powerpc64, so we really need it ASAP to make further progress).