Bug 232752 - databases/mariadb103-server: fails to build if INNOBASE option unset
Summary: databases/mariadb103-server: fails to build if INNOBASE option unset
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL: https://jira.mariadb.org/browse/MDEV-...
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2018-10-27 22:08 UTC by iron.udjin
Modified: 2018-11-25 19:44 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (brnrd)


Attachments
svn diff for databases/mariadb103-server (498 bytes, patch)
2018-10-27 23:31 UTC, Bernard Spil
brnrd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description iron.udjin 2018-10-27 22:08:25 UTC
Hello,

In case I want to have XtraDB as default storage engine and INNOBASE option is unset, mariadb103-server failes to build with output:

===>  Installing for mariadb103-server-10.3.10
===>  Checking if mariadb103-server already installed
===>   Registering installation for mariadb103-server-10.3.10
pkg-static: Unable to access file /usr/ports/databases/mariadb103-server/work/stage/usr/local/bin/innochecksum:No such file or directory
pkg-static: Unable to access file /usr/ports/databases/mariadb103-server/work/stage/usr/local/bin/mariabackup:No such file or directory
pkg-static: Unable to access file /usr/ports/databases/mariadb103-server/work/stage/usr/local/bin/mbstream:No such file or directory
*** Error code 74

Stop.
make[1]: stopped in /usr/ports/databases/mariadb103-server
*** Error code 1

# cat /var/db/ports/databases_mariadb103-server/options
# This file is auto-generated by 'make config'.
# Options for mariadb103-server-10.3.10
_OPTIONS_READ=mariadb103-server-10.3.10
_FILE_COMPLETE_OPTIONS_LIST=CONNECT_EXTRA DOCS WSREP GSSAPI_BASE GSSAPI_HEIMDAL GSSAPI_MIT GSSAPI_NONE LZ4 LZO SNAPPY ZSTD INNOBASE MROONGA OQGRAPH ROCKSDB SPHINX SPIDER TOKUDB XTRADB ZMQ MSGPACK
OPTIONS_FILE_UNSET+=CONNECT_EXTRA
OPTIONS_FILE_UNSET+=DOCS
OPTIONS_FILE_UNSET+=WSREP
OPTIONS_FILE_UNSET+=GSSAPI_BASE
OPTIONS_FILE_UNSET+=GSSAPI_HEIMDAL
OPTIONS_FILE_UNSET+=GSSAPI_MIT
OPTIONS_FILE_SET+=GSSAPI_NONE
OPTIONS_FILE_UNSET+=LZ4
OPTIONS_FILE_UNSET+=LZO
OPTIONS_FILE_UNSET+=SNAPPY
OPTIONS_FILE_UNSET+=ZSTD
OPTIONS_FILE_UNSET+=INNOBASE
OPTIONS_FILE_UNSET+=MROONGA
OPTIONS_FILE_UNSET+=OQGRAPH
OPTIONS_FILE_UNSET+=ROCKSDB
OPTIONS_FILE_UNSET+=SPHINX
OPTIONS_FILE_UNSET+=SPIDER
OPTIONS_FILE_UNSET+=TOKUDB
OPTIONS_FILE_SET+=XTRADB
OPTIONS_FILE_UNSET+=ZMQ
OPTIONS_FILE_UNSET+=MSGPACK

Thank you, Bernard
Comment 1 Bernard Spil freebsd_committer 2018-10-27 22:27:26 UTC
Thanks for reporting!

I'll try and fix that in the FreeBSD port. Can you please report that upstream (https://jira.mariadb.org) and add a link to this PR?
Comment 2 iron.udjin 2018-10-27 22:33:02 UTC
Yes, I can. But I'm not sure how to correctly explain this issue there.
Comment 3 Bernard Spil freebsd_committer 2018-10-27 22:42:32 UTC
(In reply to iron.udjin from comment #2)
Not an issue if you can't fully explain. When I have the link, I'll add more info to the JIRA issue.
Comment 4 iron.udjin 2018-10-27 22:51:59 UTC
https://jira.mariadb.org/browse/MDEV-17560
Comment 5 Bernard Spil freebsd_committer 2018-10-27 23:31:42 UTC
Created attachment 198701 [details]
svn diff for databases/mariadb103-server

Can you please check if attached patch solves your issue?
It is also a loss of functionality (but you may not need these binaries)
Comment 6 iron.udjin 2018-10-27 23:40:49 UTC
With this patch port buils fine.

P.S: mariabackup binary doesn't work:

# mariabackup --help
Segmentation fault (core dumped)

...but it's another "story".
Comment 7 Bernard Spil freebsd_committer 2018-10-28 09:13:48 UTC
For what it's worth...
The InnoDB and XtraDB engines are supposed to be drop-in replacements.
The earlier MariaDB releases (up to and including 10.1) used XtraDB . Starting with version 10.2 MariaDB switched to using InnoDB again as the default provider for InnoBase tables. Please read https://mariadb.com/kb/en/library/why-does-mariadb-102-use-innodb-instead-of-xtradb/

Unless you require something that's in XtraDB but not in InnoDB it is advisable to use InnoDB.