Bug 232789 - new port: net-p2p/aeon: a private, secure, untraceable, decentralised digital currency
Summary: new port: net-p2p/aeon: a private, secure, untraceable, decentralised digital...
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-10-29 18:25 UTC by anon4364
Modified: 2019-02-16 09:02 UTC (History)
2 users (show)

See Also:


Attachments
the shar file (2.69 KB, text/plain)
2018-10-29 18:25 UTC, anon4364
no flags Details
Removed RUN_DEPEND (2.67 KB, text/plain)
2018-10-30 11:16 UTC, anon4364
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description anon4364 2018-10-29 18:25:32 UTC
Created attachment 198743 [details]
the shar file

Aeon is a private, secure, untraceable, decentralised
digital currency.
Comment 1 Nathan 2018-10-30 02:13:27 UTC
Comment on attachment 198743 [details]
the shar file

#RUN_DEPENDS=

Take out as it's not being used
Comment 2 anon4364 2018-10-30 11:16:47 UTC
Created attachment 198770 [details]
Removed RUN_DEPEND

Removed RUN_DEPEND as it wasn't required
Comment 3 Tobias Kortkamp freebsd_committer 2019-02-02 18:36:42 UTC
Hi,

a couple of comments below that would need to be addressed if this is
to go into the tree.

- Can you please format *_DEPENDS properly?  Look at any other port
  for what this should look like.

- Directly depending on security/openssl is wrong.  Please use USES=ssl.

- Directly depending on devel/pkgconf is wrong.  It's already added
  via USES=pkgconfig anyway.

- Having doxygen in BUILD_DEPENDS is problematic as it pulls in
  large dependencies.  It would be better if this could be optional
  via a DOXYGEN option.  What is doxygen used for here?  Any way
  to disable it?

- USES=ninja can be dropped. It's the default for USES=cmake now.

- Drop GH_PROJECT.  It's set to ${PORTNAME} by default.

- Instead of GH_TAGNAME=v0.12.2.1, just set DISTVERSIONPREFIX=v

- What does portlint -AC say?

- What QA did you do?  Any build tests in Poudriere or with another
  tool?  Or a build with DEVELOPER=yes in /etc/make.conf?