Bug 232809 - math/mpfr: r483455 breaks build in patch step on 10.x
Summary: math/mpfr: r483455 breaks build in patch step on 10.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-30 09:16 UTC by Bengt Ahlgren
Modified: 2019-01-30 21:00 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (ale)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bengt Ahlgren 2018-10-30 09:16:28 UTC
The recent update of math/mpfr breaks the build:

=======================<phase: patch          >============================
===>  Patching for mpfr-4.0.1_1
===>  Applying distribution patches for mpfr-4.0.1_1
No such line 4470 in input file, ignoring
3 out of 4 hunks failed--saving rejects to doc/mpfr.info.rej
*** Error code 1

Stop.
make: stopped in /usr/ports/math/mpfr
Comment 1 Bengt Ahlgren 2018-10-30 09:18:46 UTC
Hmm, this appears to only happen on 10.x.
Comment 2 commit-hook freebsd_committer 2018-10-30 10:26:25 UTC
A commit references this bug:

Author: ale
Date: Tue Oct 30 10:26:13 UTC 2018
New revision: 483463
URL: https://svnweb.freebsd.org/changeset/ports/483463

Log:
  FreeBSD 10 still requires gpatch.

  PR:		232809
  Submitted by:	Bengt Ahlgren <bengta@sics.se>

Changes:
  head/math/mpfr/Makefile
Comment 3 Bengt Ahlgren 2018-10-30 10:33:35 UTC
Thanks for the _very_ quick response and fix!
Comment 4 Alexander Zagrebin 2018-10-30 12:50:24 UTC
(In reply to commit-hook from comment #2)

But why do we need an additional dependency when using  FreeBSD 11+?
Comment 5 denzill 2018-11-17 08:56:49 UTC
(In reply to Bengt Ahlgren from comment #1)
this is not true:
===>  Patching for mpfr-4.0.1_2
===>  Applying distribution patches for mpfr-4.0.1_2
No such line 4470 in input file, ignoring
3 out of 4 hunks failed--saving rejects to doc/mpfr.info.rej
*** Error code 1

 uname -a
FreeBSD ptah 11.1-RELEASE-p10 FreeBSD 11.1-RELEASE-p10 #0: Tue May  8 05:21:56 UTC 2018     root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC  amd64
Comment 6 denzill 2018-11-17 09:09:56 UTC
(In reply to Alexander Zagrebin from comment #4)
and with vulnerables:
 https://vuxml.FreeBSD.org/freebsd/791841a3-d484-4878-8909-92ef9ce424f4.html
Comment 7 Bernard Frauendienst 2018-11-30 18:18:25 UTC
(In reply to denzill from comment #5)

I can confirm that this also affects FreeBSD 11.1 

I'm aware that 11.1 is EOL also, but probably more widespread than 10 -- for example, in current FreeNAS stable.
Comment 8 Steve Jackson 2019-01-30 21:00:36 UTC
This is still broken on 11.1-p4

I get the following error from poudriere

=======================<phase: patch          >============================
===>  Patching for mpfr-4.0.1_2
===>  Applying distribution patches for mpfr-4.0.1_2
No such line 4470 in input file, ignoring
3 out of 4 hunks failed--saving rejects to doc/mpfr.info.rej
*** Error code 1