Bug 232843 - devel/sasm: Update to 3.10.1
Summary: devel/sasm: Update to 3.10.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Wen Heping
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-31 11:26 UTC by Martin Filla
Modified: 2018-12-05 23:11 UTC (History)
3 users (show)

See Also:
freebsd: maintainer-feedback+

Attachments
sasm.diff (1.12 KB, patch)
2018-10-31 11:26 UTC, Martin Filla 		no flags Details | Diff
sasm.diff (1.39 KB, patch)
2018-11-05 19:56 UTC, Martin Filla 		no flags Details | Diff
sasm.diff (1.89 KB, patch)
2018-11-11 12:03 UTC, Martin Filla 		freebsd: maintainer-approval+
Details | Diff
sasm.diff (1.13 KB, patch)
2018-11-25 09:40 UTC, Martin Filla 		freebsd: maintainer-approval+
Details | Diff
sasm.diff (1.50 KB, patch)
2018-11-29 15:42 UTC, Martin Filla 		freebsd: maintainer-approval+
Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Filla 2018-10-31 11:26:10 UTC 
Created attachment 198795 [details]
sasm.diff

Hello i am sending patch for update sasm 3.10.0 to 3.10.1 
Thank you.
Comment 1 Martin Filla 2018-11-05 19:56:10 UTC 
Created attachment 198991 [details]
sasm.diff

Hello wen this is update diff file
Comment 2 Martin Filla 2018-11-09 21:48:52 UTC 
ping
Comment 3 wen 2018-11-11 10:02:55 UTC 
(In reply to Sysctl from comment #2)
I am waiting for the maintainer's approvement.

wen
Comment 4 Martin Filla 2018-11-11 10:29:23 UTC 
I approve :-)
Comment 5 wen 2018-11-11 10:50:35 UTC 
(In reply to Sysctl from comment #4)

Hi,

  Would you:
   1 Generate the diff file based on up-to-date version of the portstree.
   2 Re-generate the ports' patch file .
   3 Set PR's maintainer-feedback to + 

  Thanks !

  wen
Comment 6 Martin Filla 2018-11-11 10:56:27 UTC 
I am sorry bad diff file.
Comment 7 Martin Filla 2018-11-11 12:03:43 UTC 
Created attachment 199133 [details]
sasm.diff

Hi, i sending diff file
1. Update for next version port
2. Repair name path for post-patch
3. Remove unnecessary binary blobs from pkg-plist
Comment 8 Martin Filla 2018-11-15 13:37:45 UTC 
ping
Comment 9 Wen Heping freebsd_committer freebsd_triage 2018-11-17 11:53:42 UTC 
(In reply to Sysctl from comment #8)
The build failed because of plist error, why remove bin/fasm and bin/listing ?

And files/patch-SASM.pro can not apply cleanly.

You can check it with ports-mgmt/poudriere.

wen
Comment 10 Martin Filla 2018-11-25 09:40:44 UTC 
Created attachment 199536 [details]
sasm.diff

Hello Wen,
last changes for this version
thank you
M.
Comment 11 Martin Filla 2018-11-25 10:02:25 UTC 
Binary files bin/fasm and bin/listing they will remove in future version 
because bin/fasm and bin/listing are linux binary files.
Comment 12 wen 2018-11-26 08:40:01 UTC 
(In reply to Sysctl from comment #11)
`make patch` failed again and again ...

wen
Comment 13 Martin Filla 2018-11-28 19:50:25 UTC 
Please Wen remove patch-SASM.pro
Thank you.
Comment 14 wen 2018-11-29 03:28:48 UTC 
(In reply to Sysctl from comment #13)
Without the patch , plist error :)

wen
Comment 15 Martin Filla 2018-11-29 09:29:25 UTC 
@Wen how is error message ? In last diff file isnt change in plist.
Thank you .
Comment 16 Wen Heping freebsd_committer freebsd_triage 2018-11-29 13:08:11 UTC 
(In reply to Sysctl from comment #15)
The patch patch-SASM.pro comment out the installation of the doc file.
Now you remove the patch, so doc file would be installed but not in pkg-plist.

wen
Comment 17 Martin Filla 2018-11-29 13:55:51 UTC 
(In reply to Wen Heping from comment #16)
Ok, but in last version sasm arent this doc file. I send new diff file.
Comment 18 Martin Filla 2018-11-29 15:42:16 UTC 
Created attachment 199672 [details]
sasm.diff
Comment 19 commit-hook freebsd_committer freebsd_triage 2018-11-30 06:30:46 UTC 
A commit references this bug:

Author: wen
Date: Fri Nov 30 06:30:13 UTC 2018
New revision: 486225
URL: https://svnweb.freebsd.org/changeset/ports/486225

Log:
  - Update to 3.10.1

  PR:		232843
  Submitted by:	freebsd@sysctl.cz(maintiner)

Changes:
  head/devel/sasm/Makefile
  head/devel/sasm/distinfo
  head/devel/sasm/files/
  head/devel/sasm/pkg-plist