Created attachment 198879 [details]
Patch for graphics/mupdf
Had upgraded Zathura and MuPDF on my -CURRENT box recently to
$ pkg query %n-%v | egrep '(mupdf|zathura)'
and found out that Zathura was not able to open PDF files any more.
Quick digging found out that libmupdf.so.1.13.0 wanted symbol
'cmsGetContextUserData', but it wasn't available. This symbol
is provided by the lcms2 that is bundled with MuPDF, but goes
to libmupdfthird.so.1.13.0. And fitz code from
./source/fitz/color-lcms.c wants that one (unless NO_ICC is defined
via Makethird file, but it isn't because lcms2 is bundled to the
thirdparty/ folder and Makethird checks exactly that when branches
and decides /not/ to engage NO_ICC).
I am slightly puzzled that previous version had no such problems --
no visible changes in FreeBSD port (Makefile/patches), but I hadn't
yet seen the source code of the previous MuPDF version.
The code builds fine on -CURRENT, I had contacted the maintainer, Zsolt Udvari <email@example.com>, and have his blessing.
The patch is attached and I am willing to commit it. Having hit by Grim Reaper, I need a review from one of the port committers.
A commit references this bug:
Date: Sun Feb 24 00:44:52 UTC 2019
New revision: 493732
graphics/zathura: Update to 4.3.
- update graphics/mupdf to 1.14.0
- update graphics/zathura-pdf-mupdf to 0.3.4
Approved by: tcberner (mentor), Zsolt Udvari <firstname.lastname@example.org> (maintainer), Quentin Stievenart <email@example.com> (maintainer)
Differential Revision: https://reviews.freebsd.org/D19301