Bug 232902 - graphics/mupdf: automatically pick libmupdfthird.so
Summary: graphics/mupdf: automatically pick libmupdfthird.so
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Alexandre C. Guimarães
URL:
Keywords:
Depends on: 233727
Blocks:
  Show dependency treegraph
 
Reported: 2018-11-02 06:55 UTC by Eygene Ryabinkin
Modified: 2019-02-24 21:00 UTC (History)
2 users (show)

See Also:
uzsolt: maintainer-feedback+


Attachments
Patch for graphics/mupdf (2.13 KB, patch)
2018-11-02 06:55 UTC, Eygene Ryabinkin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eygene Ryabinkin freebsd_committer 2018-11-02 06:55:41 UTC
Created attachment 198879 [details]
Patch for graphics/mupdf

Had upgraded Zathura and MuPDF on my -CURRENT box recently to
{{{
$ pkg query %n-%v | egrep '(mupdf|zathura)'
mupdf-1.13.0_1,1
zathura-0.4.0_1
zathura-cb-0.1.8_1
zathura-djvu-0.2.8_1
zathura-pdf-mupdf-0.3.3_1
zathura-ps-0.2.6_1
}}}
and found out that Zathura was not able to open PDF files any more.
Quick digging found out that libmupdf.so.1.13.0 wanted symbol
'cmsGetContextUserData', but it wasn't available.  This symbol
is provided by the lcms2 that is bundled with MuPDF, but goes
to libmupdfthird.so.1.13.0.  And fitz code from
./source/fitz/color-lcms.c wants that one (unless NO_ICC is defined
via Makethird file, but it isn't because lcms2 is bundled to the
thirdparty/ folder and Makethird checks exactly that when branches
and decides /not/ to engage NO_ICC).

I am slightly puzzled that previous version had no such problems --
no visible changes in FreeBSD port (Makefile/patches), but I hadn't
yet seen the source code of the previous MuPDF version.


The code builds fine on -CURRENT, I had contacted the maintainer, Zsolt Udvari <uzsolt@uzsolt.hu>, and have his blessing.

The patch is attached and I am willing to commit it.  Having hit by Grim Reaper, I need a review from one of the port committers.
Comment 2 commit-hook freebsd_committer 2019-02-24 00:45:10 UTC
A commit references this bug:

Author: rigoletto
Date: Sun Feb 24 00:44:52 UTC 2019
New revision: 493732
URL: https://svnweb.freebsd.org/changeset/ports/493732

Log:
  graphics/zathura: Update to 4.3.

  - update graphics/mupdf to 1.14.0
  - update graphics/zathura-pdf-mupdf to 0.3.4

  PR:		235952
  PR:		233727
  PR:		229935
  PR:		232902
  PR:		233021
  Approved by:	tcberner (mentor), Zsolt Udvari <uzsolt@uzsolt.hu> (maintainer), Quentin Stievenart <quentin.stievenart@gmail.com> (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D19301

Changes:
  head/graphics/mupdf/Makefile
  head/graphics/mupdf/distinfo
  head/graphics/mupdf/files/patch-Makefile
  head/graphics/mupdf/files/patch-Makerules
  head/graphics/mupdf/files/patch-thirdparty_lcms2_src_cmsmd5.c
  head/graphics/mupdf/pkg-plist
  head/graphics/zathura/Makefile
  head/graphics/zathura/distinfo
  head/graphics/zathura/pkg-plist
  head/graphics/zathura-pdf-mupdf/Makefile
  head/graphics/zathura-pdf-mupdf/distinfo
Comment 3 Alexandre C. Guimarães freebsd_committer 2019-02-24 21:00:29 UTC
Thanks.