Bug 232960 - science/xcrysden fails to build with GCC 8
Summary: science/xcrysden fails to build with GCC 8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks: 231590
  Show dependency tree / graph
 
Reported: 2018-11-04 12:13 UTC by Gerald Pfeifer
Modified: 2018-11-04 17:57 UTC (History)
0 users

See Also:
yuri: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerald Pfeifer freebsd_committer freebsd_triage 2018-11-04 12:13:20 UTC 
http://package22.nyi.freebsd.org/data/112amd64-default-PR231590/2018-10-29_06h48m05s/logs/errors/xcrysden-1.5.60_2.log

gfortran -fdefault-double-8 -fdefault-real-8 -O2   -c -o gengeom.o gengeom.f
gengeom.f:735:27:

          CALL GETCCOOR(DVC,AC,2,X,Y,Z,XC,YC,ZC,I,NATR)
                           1
Error: Actual argument contains too few elements for dummy argument 'b33' (6/12) at (1)
gengeom.f:740:27:

          CALL GETCCOOR(DVC,BC,2,X,Y,Z,XC,YC,ZC,I,NATR)
                           1
Error: Actual argument contains too few elements for dummy argument 'b33' (6/12) at (1)
gengeom.f:745:27:


We are working to update the default version of GCC in the Ports Collection
from GCC 7 to GCC 8, and this blocks this update, so would be great to see
addressed.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-11-04 17:26:26 UTC 
I've reported this to the xcrysden ML.
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2018-11-04 17:43:28 UTC 
(In reply to Yuri Victorovich from comment #1)
There is a patch here that apparently solves the problem:
http://www.democritos.it/pipermail/xcrysden/2018-October/001929.html
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-11-04 17:47:06 UTC 
A commit references this bug:

Author: yuri
Date: Sun Nov  4 17:46:24 UTC 2018
New revision: 484113
URL: https://svnweb.freebsd.org/changeset/ports/484113

Log:
  science/xcrysden: Fix GCC 8 build failure

  Add custom patch expanding arrays passed as function argument in question.

  Also add USES=gl.

  PR:		232960
  Reported by:	gerald

Changes:
  head/science/xcrysden/Makefile
  head/science/xcrysden/files/patch-F_gengeom.f
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-11-04 17:47:19 UTC 
Committed the patch resolving the problem.
Comment 5 Gerald Pfeifer freebsd_committer freebsd_triage 2018-11-04 17:51:24 UTC 
(In reply to Yuri Victorovich from comment #4)
> Committed the patch resolving the problem.

Thank you!
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2018-11-04 17:56:54 UTC 
(In reply to Gerald Pfeifer from comment #5)

You are welcome!

Yuri
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-11-04 17:57:19 UTC 
A commit references this bug:

Author: yuri
Date: Sun Nov  4 17:56:18 UTC 2018
New revision: 484116
URL: https://svnweb.freebsd.org/changeset/ports/484116

Log:
  science/xcrysden: Fix GCC 8 build failure (update patch)

  Change the patch to the one from the crysden ML: http://www.democritos.it/pipermail/xcrysden/2018-October/001929.html

  PR:		232960
  Submitted by:	Nick Papior nickpapior at gmail.com (to xcrysden ML)
  Suggested by:	tobik

Changes:
  head/science/xcrysden/Makefile
  head/science/xcrysden/files/patch-F_gengeom.f