Created attachment 198969 [details] svn-diff-qtoctave Unbreak qtoctave: qtoctave/src/generate_menu.cpp:282:64: error: cannot initialize return object of type 'MenuExtCallBack *' with an rvalue of type 'bool' if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) return false;
-USE_QT= designer gui network script svg xml \ - qmake_build moc_build rcc_build uic_build \ +USE_QT= corelib designer gui network script svg xml \ + qmake_build moc_build rcc_build sql uic_build \ linguisttools_build IMVHO it would be better to leave these kinds of changes out while fixing Clang 6 regressions. It makes it hard to see what kind of change actually fixed the build. I'm going to land it but without the patches that only fix warnings. This port has the problem that it uses Qt 4 which might be deprecated soon [1]. Fixing the build is a band-aid at best. The upstream website also seems to be gone. Is the project abandoned? [1] https://reviews.freebsd.org/D17741
A commit references this bug: Author: tobik Date: Mon Nov 5 22:07:09 UTC 2018 New revision: 484251 URL: https://svnweb.freebsd.org/changeset/ports/484251 Log: math/qtoctave: Unbreak build with Clang 6 qtoctave/src/generate_menu.cpp:282:64: error: cannot initialize return object of type 'MenuExtCallBack *' with an rvalue of type 'bool' if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) return false; ^~~~~ http://beefy3.nyi.freebsd.org/data/112amd64-quarterly/482201/logs/qtoctave-0.10.1_4.log PR: 232985 Submitted by: w.schwarzenfeld@utanet.at Changes: head/math/qtoctave/Makefile head/math/qtoctave/files/patch-qtoctave__src-generate_menu.cpp