By inspection, work/procenv-0.36/src/procenv.h: #if defined (HAVE_SYS_CAPABILITY_H) #include <sys/capability.h> sys/capability.h will be removed before FreeBSD 13. The (now) correct header to use on all supported (and most unsupported) versions of FreeBSD is sys/capsicum.h. There's no need for autoconf checks etc. to check for both (in the ports tree) but upstream may want to if there's a desire to build on older releases.
Created attachment 199037 [details] svn-diff-procenv Replace deprecated header with capsicum.h and update to 0.40.
Comment on attachment 199037 [details] svn-diff-procenv Project moved to GitHub [0,1] and there are newer releases there. Also see [2] from Ed. Walter, can you send the patches upstream? [0] https://launchpad.net/procenv/+announcement/13689 [1] https://github.com/jamesodhunt/procenv [2] https://github.com/jamesodhunt/procenv/issues/6
Ok, I was to fast, let's wait for upstream.
Created attachment 199039 [details] svn-diff-procenv-0.50 Ok, tried again. In this version only two occurances of capabilities.h. I deleted both, but not replaced it with capsicum.h. If I understand right, it is not needed.
Reporter is committer, assign accordingly. @Tobik Feel free to self-assign this if we (or Ed) would like to skip ports approval for Ed. Alternatively, we can ports approve the attachment for Ed to commit, though the change still needs review/QA confirmation We should also separate the 'bugfix' from the version update so that the former may be merged to quarterly. Alternatively, if the version update is bugfixes only, the whole change can be committed and merged together patch-file(s) should be commented with upstream issue/pr/commit references where available
Comment on attachment 199039 [details] svn-diff-procenv-0.50 Approved by: portmgr (unmaintained port) Pending review, QA and ports approval
Comment on attachment 199039 [details] svn-diff-procenv-0.50 Reporter to review
A commit references this bug: Author: swills Date: Fri Nov 9 16:37:09 UTC 2018 New revision: 484524 URL: https://svnweb.freebsd.org/changeset/ports/484524 Log: devel/jfrog-cli: update to 1.20.2 PR: 233026 Submitted by: Antoine Levy-Lambert <antoine.levy.lambert@gmail.com> Changes: head/devel/jfrog-cli/Makefile head/devel/jfrog-cli/distinfo head/devel/jfrog-cli/files/ head/devel/jfrog-cli/files/patch-jfrog-cli_utils_lock_utils__unix.go
I think the commit reference is in the wrong PR.
A typo jfrog-cli is bug #233036.
(In reply to w.schwarzenfeld from comment #4) > I deleted both, but not replaced > it with capsicum.h. If I understand right, it is not needed. If a port uses Capsicum it should include <sys/capsicum.h>; there are ports that want Linux capabilities and include sys/capability.h, those should not be switched to include capsicum.h. Looking at sysutils/procenv it does use Capsicum capabilities (look for cap_rights_t / cap_rights_get etc.) and should be including sys/capsicum.h on FreeBSD.
Comment on attachment 199039 [details] svn-diff-procenv-0.50 Ok, I obsolete it. platform-headers.h is not really clear for me.
Should I make the update PR before capability.h fix?
(In reply to w.schwarzenfeld from comment #13) IMO yes, do the update first then the change for capability.h.
The include of sys/capability.h was fixed with the upgrade in PR#233176.
Reopen, port has mark BROKEN in port r508153. --> In file included from platform/freebsd/platform.c:19: In file included from ./platform/freebsd/platform-freebsd.h:26: /usr/include/sys/capability.h:43:2: error: this file includes <sys/capability.h> which is deprecated [-Werror,-W#warnings] #warning this file includes <sys/capability.h> which is deprecated
Created attachment 206290 [details] svn-diff-procenv
Fixed in r508180.
ports r508180.
Thanks!