Bug 233032 - devel/subversion-book refuses to install; checks for unknown port option
Summary: devel/subversion-book refuses to install; checks for unknown port option
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-06 16:55 UTC by pl
Modified: 2019-08-08 11:28 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (lev)


Attachments
A hopefully useful patch to remove the comparison (148 bytes, patch)
2018-11-06 16:55 UTC, pl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description pl 2018-11-06 16:55:35 UTC
Created attachment 199016 [details]
A hopefully useful patch to remove the comparison

Hi there,

I'm trying to install devel/subversion-book but it fails while complaining that the DOCS option is turned off globally and therefor it wouldn't make sense to install the package:

peter@zefiris:/usr/ports/devel/subversion-book $ make build                      ===>  subversion-book-4515 it does not make sense to install dedicated           documentation if DOCS are globally disabled.                                     *** Error code 1                                                                                                                                                  Stop.                                                                            make: stopped in /usr/ports/devel/subversion-book      


At first I assumed it referred to the DOCS option in devel/subversion and I really failed to understand the logic behind this; why would it matter if I had build Subversion with documentation?

But looking into this matter a bit deeper seems to indicate that the Makefile is actually checking for a non-existing port option:

peter@zefiris:/usr/ports/devel/subversion-book $ grep -A3 -i mdoc Makefile       .if !${PORT_OPTIONS:MDOCS}                                                       IGNORE= it does not make sense to install dedicated documentation if DOCS are globally disabled                                                                   .endif                                                                                                                                  

peter@zefiris:/usr/ports/devel/subversion-book $ make showconfig                 ===> The following configuration options are available for subversion-book-4515:      HTML_SINGLE=on: Single HTML page edition                                         PDF=off: PDF edition                                                        ===> Use 'make config' to modify these settings     


... therefor I think the whole comparison should be removed and that the port should be able to build no matter what port option is or isn't turned on or off. I tried to make a patch using diff and I hope this is useful (I'll be honest: I didn't try to see if it worked).
Comment 1 Walter Schwarzenfeld freebsd_triage 2019-08-08 11:28:43 UTC
ping!