Bug 233034 - graphics/mesa-dri: update to 18.3.0
Summary: graphics/mesa-dri: update to 18.3.0
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 mailing list
URL: https://www.mesa3d.org/relnotes/18.3....
Keywords: needs-qa, patch
Depends on: 230298
  Show dependency treegraph
Reported: 2018-11-06 17:53 UTC by Jan Beich
Modified: 2018-12-08 21:21 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (x11)


Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2018-11-06 17:53:50 UTC
See review D17872 for the patch. Call for testing and maintainer timeout countdown are blocked until actual release. Schedule your review appropriately.

Let the coordination happen here.
Comment 1 Niclas Zeising freebsd_committer 2018-12-07 12:19:44 UTC
The Graphics Team decided to push off releasing this to the ports tree until after 2019Q1 is branched.
Comment 2 Jan Beich freebsd_committer 2018-12-07 12:33:08 UTC
"Decided"? Are you implying it's fine to land as soon as 2019Q1 branches to maximize post-CFT testing and minimize MFH churn?
Comment 3 Warner Losh freebsd_committer 2018-12-07 18:54:25 UTC
Since 12.0 isn't out, it's easier to manage things if we wait to commit this. Once it's out, the Q1 branch point is a convenient time to commit. People tracking the Q1 branch can live with the slightly old, but still fully functional release. If some security issue comes up and there's no patches to the current version, we can fall back to merging 18.3 to the Q1 branch. The risk is that we break things. While this has been tested on some intel hardware, we need to make sure we don't break amdgpus and that it works well with the latest drm-kmod modules. Given the critical nature of the mesa, we need positive reports of working on a variety of hardware which we don't yet have.
Comment 4 Jan Beich freebsd_committer 2018-12-08 18:58:28 UTC
(In reply to Warner Losh from comment #3)
> Since 12.0 isn't out, it's easier to manage things if we wait to commit this.

Mesa upstream appears to release new minor version every ~3 months. If 18.3.* doesn't land in ports early 2019Q1 its QA is likely to intersect with 18.4.0 (or 19.0.0). Part of QA is whatching bugzilla/lists/etc for regressions after landing, reported by users experienced enough to switch to /latest. Besides, doing updates in small/incremental steps is easier than waiting then skipping over versions which increases the risk and complicates regression tracking.

> make sure we don't break amdgpus

Similar to Intel, depends on the kernel driver: radeonkms (legacy) is probably under the most risk. Otherwise, see https://lists.freebsd.org/pipermail/freebsd-x11/2018-December/022256.html

> it works well with the latest drm-kmod modules

drm-stable-kmod is probably more important:
- selected by drm-kmod for 11.2 or /stable/11
- working SNA on xf86-video-intel[1]
- working Vulkan on AMD[2] and partially working on Intel[3]

[1] UXA (default due to legacy DRM) is slow while modesetting(4x) incurs flickering/stutter when switching workspaces back and forth here
[2] https://github.com/FreeBSDDesktop/kms-drm/issues/33
[3] https://github.com/FreeBSDDesktop/DEPRECATED-freebsd-base-graphics/issues/132
Comment 5 rkoberman 2018-12-08 21:21:38 UTC
Tested on Intel HD3000 (Sandybridge) and all is working fine so far.

glgears just under 5000 with no vsync (60 FPS with)
mpv plays back 1080p video with acceleration and minimal CPU (using libva-intel-driver)
firefox runs with acceleration and webrender once I get the command typed correctly.

So far, I see no issues at all, but I just started running it about 6 hours ago with little requirement for it other than the tests. I'll follow up if any sign of a regression shows up. Running 11.2-STABLE FreeBSD 11.2-STABLE #0 r338990.

I expect to be moving to 12.0 soon, so ability to test on 11.2 will be gone, I'm afraid. I usually move to the new version as soon as beta starts, but have just been too busy.